Source/modules/webdatabase/SQLResultSet.cpp - Issue 207453006: Oilpan: Prepare to move SQLResultSet and SQLResultSetRowList to oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/SQLResultSet.cpp

Issue 207453006: Oilpan: Prepare to move SQLResultSet and SQLResultSetRowList to oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/webdatabase/SQLResultSet.h ('k') | Source/modules/webdatabase/SQLResultSet.idl » ('j') | Source/modules/webdatabase/SQLStatementBackend.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/SQLResultSet.cpp

diff --git a/Source/modules/webdatabase/SQLResultSet.cpp b/Source/modules/webdatabase/SQLResultSet.cpp

index b467578e6675a4bc998f2629ea6d6ecaedd2195e..55b7c66a93e65dc9676776c89f206438bf01f019 100644

--- a/Source/modules/webdatabase/SQLResultSet.cpp

+++ b/Source/modules/webdatabase/SQLResultSet.cpp

@@ -31,18 +31,25 @@

#include "bindings/v8/ExceptionState.h"

#include "core/dom/ExceptionCode.h"

+#include "heap/Handle.h"

namespace WebCore {

SQLResultSet::SQLResultSet()

: m_rows(SQLResultSetRowList::create())

, m_insertId(0)

- , m_insertIdSet(false)

, m_rowsAffected(0)

+ , m_insertIdSet(false)

+ , m_isValid(false)

{

ScriptWrappable::init(this);

}

+void SQLResultSet::trace(Visitor* visitor)

+ visitor->trace(m_rows);

int64_t SQLResultSet::insertId(ExceptionState& exceptionState) const

{

// 4.11.4 - Return the id of the last row inserted as a result of the query