Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2074523003: Revert of [Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree. (Closed)

Created:
4 years, 6 months ago by dmazzoni
Modified:
4 years, 6 months ago
CC:
chromium-reviews, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree. (patchset #2 id:20001 of https://codereview.chromium.org/2075463002/ ) Reason for revert: Broke both Mac GN builders; tests are failing with errors such as: AcceleratorsCocoaBrowserTest.MainMenuAcceleratorsInMapping (run #1): [ RUN ] AcceleratorsCocoaBrowserTest.MainMenuAcceleratorsInMapping [1361:515:0615/193339:210535270587:FATAL:crashpad_client_mac.cc(411)] execvp /b/swarm_slave/work/isolated/isolated_runTnrdHD/out/Release/Chromium.app/Contents/Versions/53.0.2769.0/Chromium Framework.framework/Helpers/crashpad_handler: No such file or directory Original issue's description: > [Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree. > > As the TODO this fixes states, copytree preserves mtimes. This can cause > overbuild when building bundled products. Switch to using rsync to have more > control over copy parameters. > > BUG=297668 > R=dpranke@chromium.org > > Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f > Cr-Commit-Position: refs/heads/master@{#400047} TBR=dpranke@chromium.org,rsesek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=297668 Committed: https://crrev.com/e127bb46966c5d7eec116a9612502e1cd0ea20cf Cr-Commit-Position: refs/heads/master@{#400081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M build/toolchain/mac/copy_bundle_data.py View 2 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dmazzoni
Created Revert of [Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.
4 years, 6 months ago (2016-06-16 03:24:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074523003/1
4 years, 6 months ago (2016-06-16 03:24:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 03:25:16 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e127bb46966c5d7eec116a9612502e1cd0ea20cf Cr-Commit-Position: refs/heads/master@{#400081}
4 years, 6 months ago (2016-06-16 03:28:00 UTC) #7
Dirk Pranke
lgtm.
4 years, 6 months ago (2016-06-16 17:48:31 UTC) #8
Robert Sesek
4 years, 6 months ago (2016-06-16 17:49:24 UTC) #9
Message was sent while issue was closed.
Thanks for the revert. Trybots should have caught this but didn't, so fixing
that first before attempting any reland.

Powered by Google App Engine
This is Rietveld 408576698