MD Downloads: hide ... (more options) menu on resize

MD Downloads: hide ... (more options) menu on resize

R=michaelpg@chromium.org
BUG=613927, 620291
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f04f35b8abb4c59b77e4e0898065df829a117e95
Cr-Commit-Position: refs/heads/master@{#400281}

[Dan Beam, 2016-06-15 21:25:49]

Description was changed from

==========
MD Downloads: hide ... (more options) menu on resize

R=michaelpg@chromium.org
BUG=613927
==========

to

==========
MD Downloads: hide ... (more options) menu on resize

R=michaelpg@chromium.org
BUG=613927
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-06-15 21:58:11]

Patchset #2 (id:20001) has been deleted

[Dan Beam, 2016-06-15 21:58:18]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-06-16 00:28:18]

Description was changed from

==========
MD Downloads: hide ... (more options) menu on resize

R=michaelpg@chromium.org
BUG=613927
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: hide ... (more options) menu on resize

R=michaelpg@chromium.org
BUG=613927,620291
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-06-16 00:49:40]

yay. some minor suggestions

https://codereview.chromium.org/2074483003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/toolbar.js (right):

https://codereview.chromium.org/2074483003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_downloads/toolbar.js:65: this.boundResize_ =
function() { this.$.more.close(); }.bind(this);
if (!this.boundResize_) ?

https://codereview.chromium.org/2074483003/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/md_downloads/downloads_browsertest.js (right):

https://codereview.chromium.org/2074483003/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/md_downloads/downloads_browsertest.js:18: function
DownloadsLayoutTest() {}
isn't "layout test" an actual test type?

https://codereview.chromium.org/2074483003/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/md_downloads/layout_tests.js (right):

https://codereview.chromium.org/2074483003/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/md_downloads/layout_tests.js:5: suite('LayoutTests',
function() {
you're allowed to use spaces here, it's just a description

[Dan Beam, 2016-06-16 01:07:24]

https://codereview.chromium.org/2074483003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/toolbar.js (right):

https://codereview.chromium.org/2074483003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_downloads/toolbar.js:65: this.boundResize_ =
function() { this.$.more.close(); }.bind(this);
On 2016/06/16 00:49:40, michaelpg wrote:
> if (!this.boundResize_) ?

Done.

https://codereview.chromium.org/2074483003/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/md_downloads/downloads_browsertest.js (right):

https://codereview.chromium.org/2074483003/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/md_downloads/downloads_browsertest.js:18: function
DownloadsLayoutTest() {}
On 2016/06/16 00:49:40, michaelpg wrote:
> isn't "layout test" an actual test type?

it is in blink

https://codereview.chromium.org/2074483003/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/md_downloads/layout_tests.js (right):

https://codereview.chromium.org/2074483003/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/md_downloads/layout_tests.js:5: suite('LayoutTests',
function() {
On 2016/06/16 00:49:40, michaelpg wrote:
> you're allowed to use spaces here, it's just a description

yeah, I know.  aight fine, spaces you get.

I think when I did this originally (and simply moved it in this CL) I was
following some other half-baked convention

[michaelpg, 2016-06-16 22:06:10]

whoops, thought i lgtm'd already

[Dan Beam, 2016-06-16 22:10:33]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-06-16 22:11:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2074483003/100001

[commit-bot: I haz the power, 2016-06-16 22:34:32]

Description was changed from

==========
MD Downloads: hide ... (more options) menu on resize

R=michaelpg@chromium.org
BUG=613927,620291
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: hide ... (more options) menu on resize

R=michaelpg@chromium.org
BUG=613927,620291
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-16 22:34:33]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-06-16 22:35:59]

Description was changed from

==========
MD Downloads: hide ... (more options) menu on resize

R=michaelpg@chromium.org
BUG=613927,620291
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: hide ... (more options) menu on resize

R=michaelpg@chromium.org
BUG=613927,620291
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f04f35b8abb4c59b77e4e0898065df829a117e95
Cr-Commit-Position: refs/heads/master@{#400281}
==========

[commit-bot: I haz the power, 2016-06-16 22:36:00]

Patchset 4 (id:??) landed as
https://crrev.com/f04f35b8abb4c59b77e4e0898065df829a117e95
Cr-Commit-Position: refs/heads/master@{#400281}