Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2074473002: [Chromecast] Aggregate errors in multizone backend test. (Closed)

Created:
4 years, 6 months ago by jameswest
Modified:
4 years, 6 months ago
Reviewers:
slan, kmackay
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Aggregate errors in multizone backend test. Use only one effects stream. Use PCM format supported by AMP. BUG=internal b/27694837 TEST=cast_multizone_backend_unittests Committed: https://crrev.com/a7c82456f81ecf71bceaa36cf31841b324556ded Cr-Commit-Position: refs/heads/master@{#400067}

Patch Set 1 #

Total comments: 2

Patch Set 2 : [Chromecast] Aggregate errors in multizone backend test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M chromecast/media/cma/backend/multizone_backend_unittest.cc View 1 8 chunks +49 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
jameswest
4 years, 6 months ago (2016-06-15 20:22:26 UTC) #4
kmackay
https://codereview.chromium.org/2074473002/diff/1/chromecast/media/cma/backend/multizone_backend_unittest.cc File chromecast/media/cma/backend/multizone_backend_unittest.cc (right): https://codereview.chromium.org/2074473002/diff/1/chromecast/media/cma/backend/multizone_backend_unittest.cc#newcode260 chromecast/media/cma/backend/multizone_backend_unittest.cc:260: average_rendering_delay_error_us_ = Seems like it would be more accurate ...
4 years, 6 months ago (2016-06-15 20:26:48 UTC) #5
jameswest
https://codereview.chromium.org/2074473002/diff/1/chromecast/media/cma/backend/multizone_backend_unittest.cc File chromecast/media/cma/backend/multizone_backend_unittest.cc (right): https://codereview.chromium.org/2074473002/diff/1/chromecast/media/cma/backend/multizone_backend_unittest.cc#newcode260 chromecast/media/cma/backend/multizone_backend_unittest.cc:260: average_rendering_delay_error_us_ = On 2016/06/15 20:26:48, kmackay wrote: > Seems ...
4 years, 6 months ago (2016-06-15 21:41:01 UTC) #6
kmackay
lgtm
4 years, 6 months ago (2016-06-15 22:52:10 UTC) #7
slan
LGTM
4 years, 6 months ago (2016-06-15 22:53:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074473002/40001
4 years, 6 months ago (2016-06-16 00:05:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-16 01:18:16 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 01:18:18 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 01:19:57 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7c82456f81ecf71bceaa36cf31841b324556ded
Cr-Commit-Position: refs/heads/master@{#400067}

Powered by Google App Engine
This is Rietveld 408576698