Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2074453003: Move ScopedIPCSupport to mojo/edk/embedder and the mojo::edk namespace. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScopedIPCSupport to mojo/edk/embedder and the mojo::edk namespace. BUG=604282 Committed: https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9 Cr-Commit-Position: refs/heads/master@{#400343}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Lint and component build fix. #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -145 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.h View 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_thread_impl.h View 2 chunks +7 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ipc/mojo/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
D ipc/mojo/scoped_ipc_support.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ipc/mojo/scoped_ipc_support.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M mojo/edk/embedder/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/edk/embedder/scoped_ipc_support.h View 1 2 2 chunks +12 lines, -9 lines 0 comments Download
A + mojo/edk/embedder/scoped_ipc_support.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/mojo_edk.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/message_replay/message_replay.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
Anand Mistry (off Chromium)
4 years, 6 months ago (2016-06-16 00:57:10 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-16 07:26:08 UTC) #3
Anand Mistry (off Chromium)
jam@chromium.org: For owners everywhere. I could TBR, but rather get another eyeball. Also, you asked ...
4 years, 6 months ago (2016-06-16 08:33:01 UTC) #5
jam
lgtm
4 years, 6 months ago (2016-06-16 16:28:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074453003/40001
4 years, 6 months ago (2016-06-16 21:27:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/202098) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-16 21:33:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074453003/60001
4 years, 6 months ago (2016-06-16 23:26:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/154299) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-16 23:48:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074453003/60001
4 years, 6 months ago (2016-06-17 03:13:44 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-17 03:34:14 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 03:36:47 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cafcdff609c59a27cea0538013666216c42e2bd9
Cr-Commit-Position: refs/heads/master@{#400343}

Powered by Google App Engine
This is Rietveld 408576698