Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2074453002: Add missing include for compilation with latest Xcode. (Closed)

Created:
4 years, 6 months ago by justincohen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing include for compilation with latest Xcode. reading_list_model_storage.h needs an #include <vector>. BUG=619813 Committed: https://crrev.com/dec23efb79d7abad4600767df450f67859a199b7 Cr-Commit-Position: refs/heads/master@{#399974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/chrome/browser/reading_list/reading_list_model_storage.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
justincohen
ptal
4 years, 6 months ago (2016-06-15 18:06:43 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years, 6 months ago (2016-06-15 18:10:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074453002/1
4 years, 6 months ago (2016-06-15 18:10:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 18:44:34 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 18:44:36 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 18:46:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dec23efb79d7abad4600767df450f67859a199b7
Cr-Commit-Position: refs/heads/master@{#399974}

Powered by Google App Engine
This is Rietveld 408576698