[InputEvent] Dispatch 'input' event for ContentEditable and typing on Input element

[InputEvent] Dispatch 'input' event for ContentEditable and typing on Input element

This CL sends 'input' event from both user actions and execCommand (for backward interoperability).

'beforeinput' cannot be put in the similar location (e.g. CompositeEditCommand::apply()) because |CompositeEditCommand| has no information about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875
Committed: https://crrev.com/e8defdccba078e920f52ac20728d2f918c45b2e6
Cr-Commit-Position: refs/heads/master@{#401505}

[chongz, 2016-06-22 00:36:05]

Description was changed from

==========
Send InputEvent 'input' after editable content changed

BUG=585875
==========

to

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged
3. HTMLFormControlElement set value

This CL changed 1) and 2) to InputEvent, and left 3) unchanged.

BUG=585875
==========

[chongz, 2016-06-22 00:46:38]

Description was changed from

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged
3. HTMLFormControlElement set value

This CL changed 1) and 2) to InputEvent, and left 3) unchanged.

BUG=585875
==========

to

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged
3. HTMLFormControlElement set value

This CL changed 1) and 2) to InputEvent (for both user action and execCommand),
and left 3) unchanged.

See discussion about sending 'input' for execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

BUG=585875
==========

[chongz, 2016-06-22 03:22:05]

Description was changed from

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged
3. HTMLFormControlElement set value

This CL changed 1) and 2) to InputEvent (for both user action and execCommand),
and left 3) unchanged.

See discussion about sending 'input' for execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

BUG=585875
==========

to

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing

This CL sends 'input' event on both user actions and execCommand (for backward
interoperability).

See discussions about execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch InputEvent, and left 3) unchanged.

BUG=585875
==========

[chongz, 2016-06-22 03:25:09]

Description was changed from

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing

This CL sends 'input' event on both user actions and execCommand (for backward
interoperability).

See discussions about execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch InputEvent, and left 3) unchanged.

BUG=585875
==========

to

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing

This CL sends 'input' event on both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be dispatched here because |CompositeEditCommand| has no
information about event source.

See discussions about execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch InputEvent, and left 3) unchanged.

BUG=585875
==========

[chongz, 2016-06-22 03:53:52]

Patchset #3 (id:40001) has been deleted

[chongz, 2016-06-22 04:22:41]

Description was changed from

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing

This CL sends 'input' event on both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be dispatched here because |CompositeEditCommand| has no
information about event source.

See discussions about execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch InputEvent, and left 3) unchanged.

BUG=585875
==========

to

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing on Input
element

This CL sends 'input' event for both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be put in the similar location (e.g.
CompositeEditCommand::apply()) because |CompositeEditCommand| has no information
about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875
==========

[chongz, 2016-06-22 04:56:57]

Description was changed from

==========
[InputEvent] Dispatch InputEvent 'input' for ContentEditable and typing on Input
element

This CL sends 'input' event for both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be put in the similar location (e.g.
CompositeEditCommand::apply()) because |CompositeEditCommand| has no information
about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875
==========

to

==========
[InputEvent] Dispatch 'input' event for ContentEditable and typing on Input
element

This CL sends 'input' event for both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be put in the similar location (e.g.
CompositeEditCommand::apply()) because |CompositeEditCommand| has no information
about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875
==========

[chongz, 2016-06-22 04:58:51]

Description was changed from

==========
[InputEvent] Dispatch 'input' event for ContentEditable and typing on Input
element

This CL sends 'input' event for both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be put in the similar location (e.g.
CompositeEditCommand::apply()) because |CompositeEditCommand| has no information
about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875
==========

to

==========
[InputEvent] Dispatch 'input' event for ContentEditable and typing on Input
element

This CL sends 'input' event from both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be put in the similar location (e.g.
CompositeEditCommand::apply()) because |CompositeEditCommand| has no information
about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875
==========

[chongz, 2016-06-22 05:14:05]

Patchset #1 (id:1) has been deleted

[chongz, 2016-06-22 05:14:13]

Patchset #1 (id:20001) has been deleted

[chongz, 2016-06-22 05:14:23]

Patchset #1 (id:60001) has been deleted

[chongz, 2016-06-22 05:14:36]

Patchset #1 (id:80001) has been deleted

[chongz, 2016-06-22 05:16:50]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2016-06-22 05:16:52]

Hi yosin@, this CL sends 'input' event with |inputType|, PTAL, thanks!

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-inputtype.html
(right):

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/events/inputevents/before-input-inputtype.html:18:
txt.addEventListener('input', function(event) {
Actually there are bunch of existing 'input' event tests (and I got some hard
time fixing them), so I only updated this single one :)

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:110:
target->dispatchScopedEvent(inputEvent);
I have to check |FrameSelection::isAvailable()| if I'm using |dispatchEvent()|,
but I guess it should be fine with |dispatchScopedEvent()|?

[yosin_UTC9, 2016-06-22 06:29:25]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-06-22 06:29:25]

lgtm

+tkent@ for Form related changes.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:110:
target->dispatchScopedEvent(inputEvent);
On 2016/06/22 at 05:16:52, chongz wrote:
> I have to check |FrameSelection::isAvailable()| if I'm using
|dispatchEvent()|, but I guess it should be fine with |dispatchScopedEvent()|?

Not sure. Why should we need to check |FrameSelection::isAvailable()|? Selection
availability and event dispatch aren't related.

[tkent, 2016-06-22 06:53:21]

This needs a test to check various editing operations produce correct
|inputType| and |isComposing| values.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:121: InputEvent::InputType
inputTypeFromCommand(CompositeEditCommand* command)
The argument type should be |const CompositeEditCommand*| or |const
CompositeEditCommand&|.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:124: TypingCommand*
typingCommand = static_cast<TypingCommand*>(command);
Please avoid bare static_cast<>.  TypingCommand should have
DEFINE_TYPE_CAST(TypingCommand, CompositeEditCommand, command,
command->isTypingCommand(), command.isTypingCommad()), and we should use
toTypingCommand(command) here.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:150:
InputEvent::EventIsComposing isComposingFromCommand(CompositeEditCommand*
command)
The argument type should be |const CompositeEditCommand*| or |const
CompositeEditCommand&|.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:152: if
(command->isTypingCommand() &&
static_cast<TypingCommand*>(command)->compositionType() !=
TypingCommand::TextCompositionNone)
We should use toTypingCommand(command).

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/events/InputEvent.cpp (right):

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/events/InputEvent.cpp:96: // TODO(ojan): We
should find a way to prevent conversion like String->enum->String just in order
to use initializer.
why ojan?

[chongz, 2016-06-22 18:49:31]

Patchset #2 (id:120001) has been deleted

[chongz, 2016-06-22 21:15:34]

Patchset #2 (id:40002) has been deleted

[chongz, 2016-06-23 00:32:07]

tkent@ I've added tests about execCommand and isComposing, but I'm not sure
what's the expected behavior for forms... ('input' won't fire on checkbox
https://crbug.com/534245) 

PTAL, thanks!

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:110:
target->dispatchScopedEvent(inputEvent);
On 2016/06/22 06:29:25, Yosi_UTC9 wrote:
> On 2016/06/22 at 05:16:52, chongz wrote:
> > I have to check |FrameSelection::isAvailable()| if I'm using
> |dispatchEvent()|, but I guess it should be fine with |dispatchScopedEvent()|?
> 
> Not sure. Why should we need to check |FrameSelection::isAvailable()|?
Selection
> availability and event dispatch aren't related.

It's about test "editing/pasteboard/paste-removing-iframe.html", but never-mind
I've figured out how |EventQueueScope| works. :)

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:121: InputEvent::InputType
inputTypeFromCommand(CompositeEditCommand* command)
On 2016/06/22 06:53:21, tkent wrote:
> The argument type should be |const CompositeEditCommand*| or |const
> CompositeEditCommand&|.

Done.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:124: TypingCommand*
typingCommand = static_cast<TypingCommand*>(command);
On 2016/06/22 06:53:21, tkent wrote:
> Please avoid bare static_cast<>.  TypingCommand should have
> DEFINE_TYPE_CAST(TypingCommand, CompositeEditCommand, command,
> command->isTypingCommand(), command.isTypingCommad()), and we should use
> toTypingCommand(command) here.

Done.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:144: return
InputEvent::InputType::Bold;
Actually text styling commands are a little bit complex, so I will add them
later.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:150:
InputEvent::EventIsComposing isComposingFromCommand(CompositeEditCommand*
command)
On 2016/06/22 06:53:21, tkent wrote:
> The argument type should be |const CompositeEditCommand*| or |const
> CompositeEditCommand&|.

Done.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/Editor.cpp:152: if
(command->isTypingCommand() &&
static_cast<TypingCommand*>(command)->compositionType() !=
TypingCommand::TextCompositionNone)
On 2016/06/22 06:53:21, tkent wrote:
> We should use toTypingCommand(command).
> 

Done.

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/events/InputEvent.cpp (right):

https://codereview.chromium.org/2074423004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/events/InputEvent.cpp:96: // TODO(ojan): We
should find a way to prevent conversion like String->enum->String just in order
to use initializer.
On 2016/06/22 06:53:21, tkent wrote:
> why ojan?

This is the similar issue as in |InputEvent::createBeforeInput()| and ojan@
wanted me to add this in a previous CL.

See:
https://codereview.chromium.org/1752933002/diff2/80001:100001/third_party/Web...

https://codereview.chromium.org/2074423004/diff/150001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
(right):

https://codereview.chromium.org/2074423004/diff/150001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp:380:
EXPECT_STREQ("beforeinput.isComposing:true;input.isComposing:true;",
document().title().utf8().data());
Testing |isComposing|

[tkent, 2016-06-23 00:42:56]

lgtm

[chongz, 2016-06-23 01:24:41]

The CQ bit was checked by chongz@chromium.org

[chongz, 2016-06-23 01:24:41]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2074423004/#ps150001
(title: "tkent's review")

[commit-bot: I haz the power, 2016-06-23 01:25:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2074423004/150001

[commit-bot: I haz the power, 2016-06-23 01:34:10]

Description was changed from

==========
[InputEvent] Dispatch 'input' event for ContentEditable and typing on Input
element

This CL sends 'input' event from both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be put in the similar location (e.g.
CompositeEditCommand::apply()) because |CompositeEditCommand| has no information
about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875
==========

to

==========
[InputEvent] Dispatch 'input' event for ContentEditable and typing on Input
element

This CL sends 'input' event from both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be put in the similar location (e.g.
CompositeEditCommand::apply()) because |CompositeEditCommand| has no information
about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875
==========

[commit-bot: I haz the power, 2016-06-23 01:34:12]

Committed patchset #2 (id:150001)

[commit-bot: I haz the power, 2016-06-23 01:38:29]

Description was changed from

==========
[InputEvent] Dispatch 'input' event for ContentEditable and typing on Input
element

This CL sends 'input' event from both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be put in the similar location (e.g.
CompositeEditCommand::apply()) because |CompositeEditCommand| has no information
about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875
==========

to

==========
[InputEvent] Dispatch 'input' event for ContentEditable and typing on Input
element

This CL sends 'input' event from both user actions and execCommand (for backward
interoperability).

'beforeinput' cannot be put in the similar location (e.g.
CompositeEditCommand::apply()) because |CompositeEditCommand| has no information
about event source.

See discussions about 'input' and execCommand:
https://github.com/w3c/editing/issues/43#issuecomment-227246106

Implementation details:

The old 'input' Event came from 3 places:
1. TypingCommand -> webkitEditableContentChanged -> 'input'
2. Non-typing CompositeEditCommand -> webkitEditableContentChanged -> 'input'
3. Forms set value and checked -> 'input'

This CL changed 1) and 2) to dispatch real InputEvent, and left 3) unchanged.

BUG=585875

Committed: https://crrev.com/e8defdccba078e920f52ac20728d2f918c45b2e6
Cr-Commit-Position: refs/heads/master@{#401505}
==========

[commit-bot: I haz the power, 2016-06-23 01:38:30]

Patchset 2 (id:??) landed as
https://crrev.com/e8defdccba078e920f52ac20728d2f918c45b2e6
Cr-Commit-Position: refs/heads/master@{#401505}