Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2074403002: V8: Remove obsolete environment variables (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Remove obsolete environment variables The target compiler for arm is controlled in v8's gyp files now. BUG=474921 Committed: https://chromium.googlesource.com/chromium/tools/build/+/4e6b1681e8c0a5674c5d5f6ad3acd403dedba3e7 Committed: https://chromium.googlesource.com/chromium/tools/build/+/86f129da1b411424a7241faaf846deca9bb3380c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -24 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/v8/config.py View 1 chunk +0 lines, -6 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json View 3 chunks +2 lines, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Michael Achenbach
PTAL. This is set already here: https://cs.chromium.org/chromium/src/v8/gypfiles/standalone.gypi?q=standalone.gypi&sq=package:chromium&dr=C&l=1344 Tested locally...
4 years, 6 months ago (2016-06-20 09:00:35 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-20 11:31:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074403002/1
4 years, 6 months ago (2016-06-20 11:39:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/4e6b1681e8c0a5674c5d5f6ad3acd403dedba3e7
4 years, 6 months ago (2016-06-20 11:43:13 UTC) #9
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2084523002/ by machenbach@chromium.org. ...
4 years, 6 months ago (2016-06-20 12:04:09 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074403002/1
4 years, 6 months ago (2016-06-20 12:11:56 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 12:15:07 UTC) #15
Michael Achenbach
Relanding - fixed internal...
4 years, 6 months ago (2016-06-20 12:16:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074403002/1
4 years, 6 months ago (2016-06-20 12:16:26 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/86f129da1b411424a7241faaf846deca9bb3380c
4 years, 6 months ago (2016-06-20 12:19:46 UTC) #20
kjellander_chromium
4 years, 6 months ago (2016-06-20 13:56:28 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698