Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 2074393002: Clean up shadow-dom layout tests so that they are well organized (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up shadow-dom layout tests so that they are well organized Renames and organize tests in LayoutTests/shadow-dom/ so that we can understand each test's purpose more easily. BUG=531990 Committed: https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648 Cr-Commit-Position: refs/heads/master@{#401209}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-21 lines, -1019 lines) Patch
A + third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-mode.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-safelist.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/attachShadow-safelist.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/caret-range-from-point-left-of-shadow.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-inner-scope-important.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-inner-scope-important-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-multiple-shadow-with-host-rules.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-outer-scope.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-outer-scope-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-outer-scope2.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-outer-scope2-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-slot-distributed.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-slot-distributed-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/cascade-upgrade-from-v0-to-v1.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/closed-mode-deep-combinator-and-shadow-pseudo.html View 1 chunk +0 lines, -154 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/closed-mode-deep-combinators.html View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/closed-mode-deep-combinators-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-inner-scope-important.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-inner-scope-important-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-multiple-shadow-with-host-rules.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-outer-scope.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-outer-scope-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-outer-scope2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-outer-scope2-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-slot-distributed.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-slot-distributed-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-cascade-upgrade-from-v0-to-v1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-style-inherit.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/css-style-inherit-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/focus-navagation-slots.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/focus-navigation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/focus-navigation-slot-fallback.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/focus-navigation-slot-with-tabindex.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/inherit-into-slotted.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/inherit-into-slotted-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/labelsnodelist-in-shadow.html View 1 chunk +0 lines, -16 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/nodetree-labels-node-list.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/nodetree-radio-node-list.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/radionodelist-in-shadow.html View 1 chunk +0 lines, -18 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/range-caret-range-from-point-left-of-shadow.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/range-surround-contents.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/scoped-events-by-ua-stopped.html View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/shadowroot-mode.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slot-assigned-slot.html View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slot-fallback-focus.html View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/slot-with-tabindex.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/surround-contents-with-shadow-dom.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/tabindex-slot.html View 1 chunk +0 lines, -73 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinator-and-shadow-pseudo-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinators.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/v0/closed-mode-deep-combinators-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074393002/1
4 years, 6 months ago (2016-06-20 06:13:02 UTC) #2
hayato
PTAL
4 years, 6 months ago (2016-06-20 06:18:55 UTC) #9
kochi
lgtm
4 years, 6 months ago (2016-06-20 07:12:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074393002/1
4 years, 6 months ago (2016-06-20 07:21:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241513)
4 years, 6 months ago (2016-06-20 10:09:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074393002/1
4 years, 6 months ago (2016-06-22 03:40:41 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 04:52:40 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 04:54:26 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/695bbbd8361fff98468f0602c1df26008410a648
Cr-Commit-Position: refs/heads/master@{#401209}

Powered by Google App Engine
This is Rietveld 408576698