Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2074363002: skip neon intrinsics in libpng when neon is not available (Closed)

Created:
4 years, 6 months ago by Mostyn Bramley-Moore
Modified:
4 years, 6 months ago
Reviewers:
msarett, msarett1, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

skip neon intrinsics in libpng when neon is not available Followup to https://codereview.chromium.org/2021403002 BUG=599917, 618061 Committed: https://crrev.com/d66b57b0f0f5e8673612fc58fe9656a6991d6a69 Cr-Commit-Position: refs/heads/master@{#400714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/libpng/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/libpng/libpng.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074363002/1
4 years, 6 months ago (2016-06-19 22:24:20 UTC) #2
Mostyn Bramley-Moore
@jam, msarett: the recent libpng upgrade broke non-neon arm builds. This should hopefully fix that. ...
4 years, 6 months ago (2016-06-19 22:28:41 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-19 23:55:54 UTC) #6
msarett
LGTM! Thanks for this fix! I didn't realize that Chrome still supports Arm without Neon.
4 years, 6 months ago (2016-06-20 12:53:31 UTC) #8
jam
lgtm
4 years, 6 months ago (2016-06-20 15:34:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074363002/1
4 years, 6 months ago (2016-06-20 17:29:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 17:36:03 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 17:46:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d66b57b0f0f5e8673612fc58fe9656a6991d6a69
Cr-Commit-Position: refs/heads/master@{#400714}

Powered by Google App Engine
This is Rietveld 408576698