Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: pkg/polymer_expressions/test/syntax_test.dart

Issue 207433002: Changes in polymer-expressions to prepare for codegen in polymer: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer_expressions/test/syntax_test.dart
diff --git a/pkg/polymer_expressions/test/syntax_test.dart b/pkg/polymer_expressions/test/syntax_test.dart
index b7e6592460d2ea63018e3b583957605dc5652a6a..618f999c496ca0168e7eb7d4e45c6ede16322628 100644
--- a/pkg/polymer_expressions/test/syntax_test.dart
+++ b/pkg/polymer_expressions/test/syntax_test.dart
@@ -5,7 +5,6 @@
import 'dart:async';
import 'dart:html';
-import 'package:logging/logging.dart';
import 'package:observe/observe.dart';
import 'package:observe/mirrors_used.dart'; // make test smaller.
import 'package:polymer_expressions/polymer_expressions.dart';
@@ -37,7 +36,7 @@ main() {
templateBind(query('#test'))
..bindingDelegate = new PolymerExpressions()
..model = person;
- return new Future.delayed(new Duration()).then((_) {
+ return new Future(() {}).then((_) {
InputElement input = query('#input');
expect(input.value, 'John');
input.focus();
@@ -64,22 +63,19 @@ main() {
});
test('should silently handle bad variable names', () {
- var logger = new Logger('polymer_expressions');
- var logFuture = logger.onRecord.toList();
- testDiv.nodes.add(new Element.html('''
- <template id="test" bind>{{ foo }}</template>'''));
- templateBind(query('#test'))
- ..bindingDelegate = new PolymerExpressions()
- ..model = [];
- return new Future(() {
- logger.clearListeners();
- return logFuture.then((records) {
- expect(records.length, 1);
- expect(records.first.message,
- contains('Error evaluating expression'));
- expect(records.first.message, contains('foo'));
- });
+ var completer = new Completer();
+ runZoned(() {
+ testDiv.nodes.add(new Element.html('''
+ <template id="test" bind>{{ foo }}</template>'''));
+ templateBind(query('#test'))
+ ..bindingDelegate = new PolymerExpressions()
+ ..model = [];
+ return new Future(() {});
+ }, onError: (e, s) {
+ expect('$e', contains('foo'));
+ completer.complete(true);
});
+ return completer.future;
});
});
}

Powered by Google App Engine
This is Rietveld 408576698