chrome/browser/ui/gtk/first_run_dialog.cc - Issue 20743002: Do not CreateSentinel until after the process singleton has been grabbed by the current process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/first_run_dialog.cc

Issue 20743002: Do not CreateSentinel until after the process singleton has been grabbed by the current process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge latest version of https://codereview.chromium.org/20483002/ Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/first_run_dialog.mm ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/first_run_dialog.cc

diff --git a/chrome/browser/ui/gtk/first_run_dialog.cc b/chrome/browser/ui/gtk/first_run_dialog.cc

index f28925c45925f8814f1be73f67ff6ea512e2a814..eca4ef29afce9a021f92cab39788d1da4cacffde 100644

--- a/chrome/browser/ui/gtk/first_run_dialog.cc

+++ b/chrome/browser/ui/gtk/first_run_dialog.cc

@@ -160,9 +160,6 @@ void FirstRunDialog::OnResponseDialog(GtkWidget* widget, int response) {

if (dialog_)

gtk_widget_hide_all(dialog_);

- // Mark that first run has ran.

- first_run::CreateSentinel();

// Check if user has opted into reporting.

if (report_crashes_ &&

gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(report_crashes_))) {

« no previous file with comments | « chrome/browser/ui/cocoa/first_run_dialog.mm ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »