Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Side by Side Diff: chrome/browser/first_run/first_run.h

Issue 20743002: Do not CreateSentinel until after the process singleton has been grabbed by the current process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge latest version of https://codereview.chromium.org/20483002/ Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/first_run/first_run.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_ 5 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
6 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_ 6 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 std::vector<GURL> new_tabs; 84 std::vector<GURL> new_tabs;
85 std::vector<GURL> bookmarks; 85 std::vector<GURL> bookmarks;
86 std::string import_bookmarks_path; 86 std::string import_bookmarks_path;
87 std::string variations_seed; 87 std::string variations_seed;
88 std::string suppress_default_browser_prompt_for_version; 88 std::string suppress_default_browser_prompt_for_version;
89 }; 89 };
90 90
91 // Returns true if this is the first time chrome is run for this user. 91 // Returns true if this is the first time chrome is run for this user.
92 bool IsChromeFirstRun(); 92 bool IsChromeFirstRun();
93 93
94 // Creates the sentinel file that signals that chrome has been configured. 94 // Creates the first run sentinel if needed. This should only be called after
95 bool CreateSentinel(); 95 // the process singleton has been grabbed by the current process
96 // (http://crbug.com/264694).
97 void CreateSentinelIfNeeded();
96 98
97 // Get RLZ ping delay pref name. 99 // Get RLZ ping delay pref name.
98 std::string GetPingDelayPrefName(); 100 std::string GetPingDelayPrefName();
99 101
100 // Register user preferences used by the MasterPrefs structure. 102 // Register user preferences used by the MasterPrefs structure.
101 void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry); 103 void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
102 104
103 // Removes the sentinel file created in ConfigDone(). Returns false if the 105 // Removes the sentinel file created in ConfigDone(). Returns false if the
104 // sentinel file could not be removed. 106 // sentinel file could not be removed.
105 bool RemoveSentinel(); 107 bool RemoveSentinel();
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 const content::NotificationDetails& details) OVERRIDE; 194 const content::NotificationDetails& details) OVERRIDE;
193 195
194 content::NotificationRegistrar registrar_; 196 content::NotificationRegistrar registrar_;
195 197
196 DISALLOW_COPY_AND_ASSIGN(FirstRunBubbleLauncher); 198 DISALLOW_COPY_AND_ASSIGN(FirstRunBubbleLauncher);
197 }; 199 };
198 200
199 } // namespace first_run 201 } // namespace first_run
200 202
201 #endif // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_ 203 #endif // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
OLDNEW
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | chrome/browser/first_run/first_run.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698