Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: BUILD.gn

Issue 2074283002: Remove natives_blob.bin's arch dependence in Android. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: embedded Android logic Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 74a41e587988be9c48f69a3be3f16377a3ed6598..34031d370fe8cd5ef96be1f55ed4c103051535ec 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -515,8 +515,16 @@ if (is_android) {
deps = [
"//v8",
]
- renaming_sources = v8_external_startup_data_renaming_sources
- renaming_destinations = v8_external_startup_data_renaming_destinations
+ sources = [
+ "$root_out_dir/natives_blob.bin",
+ ]
+ renaming_sources = [ "$root_out_dir/snapshot_blob.bin" ]
+ if (current_cpu == "arm" || current_cpu == "x86" ||
+ current_cpu == "mipsel") {
+ renaming_destinations = [ "snapshot_blob_32.bin" ]
Yang 2016/06/22 12:59:50 Does this actually work? in src/startup-data-util.
michaelbai 2016/06/22 16:00:37 This target "v8_external_startup_data_assets" isn'
+ } else {
+ renaming_destinations = [ "snapshot_blob_64.bin" ]
+ }
disable_compression = true
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698