git cl test framework: improve debuggability of expected calls.

git cl test framework: improve debuggability of expected calls.

R=phajdan.jr@chromium.org
BUG=

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9d20675998f69ae543c3ebed4bcc14f748f3797e

[tandrii(chromium), 2016-06-17 19:04:39]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 19:04:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2074233002/1

[tandrii(chromium), 2016-06-17 19:06:37]

PTAL

the output looks like this if tests fail:

ERROR:root:@29  Expected: (['git', 'log', '--pretty=format:%s\n\n%b',
'fake_ancestor_sha..HEAD'],)   Actual: (['git', 'config', '--bool',
'gerrit.override-squash-uploads'],)

A few prior calls:
  @19: (['git', 'config', 'gitcl.remotebranch'],)
  @20: (['git', 'rev-list', '^fake_ancestor', 'refs/remotes/origin/master'],)
  @21: (['git', 'rev-parse', '--show-cdup'],)
  @22: (['git', 'rev-parse', 'HEAD'],)
  @23: (['git', 'diff', '--name-status', '--no-renames', '-r',
'fake_ancestor_sha...', '.'],)
  @24: (['git', 'config', 'branch.master.gerritpatchset'],)
  @25: (['git', 'log', '--pretty=format:%s%n%n%b', 'fake_ancestor_sha...'],)
  @26: (['git', 'config', 'user.email'],)
  @27: (['git', 'diff', '--no-ext-diff', '--stat', '--find-copies-harder',
'-l100000', '-C50', 'fake_ancestor_sha', 'HEAD'],)
  @28: (['git', 'config', '--bool', 'gerrit.override-squash-uploads'],)

This (expected):
  @29: (['git', 'log', '--pretty=format:%s\n\n%b', 'fake_ancestor_sha..HEAD'],)
This (actual):
  @29: (['git', 'config', '--bool', 'gerrit.override-squash-uploads'],)

A few following expected calls:
  @30: (False,)
  @31: (['git', 'log', '--pretty=format:%s\n\n%b', 'fake_ancestor_sha..HEAD'],)
  @32: (['git', 'commit', '--amend', '-m', 'desc\n\nBUG=\n'],)
  @33: (['git', 'log', '--pretty=format:%s\n\n%b', 'fake_ancestor_sha..HEAD'],)
  @34: (['git', 'rev-list', 'origin/refs/heads/master..HEAD'],)
  @35: (['git', 'config', 'rietveld.cc'],)
  @36: (['git', 'push', 'origin',
'HEAD:refs/for/refs/heads/master%notify=NONE,cc=joe@example.com'],)
  @37: (['git', 'rev-parse', 'HEAD'],)
  @38: (['git', 'symbolic-ref', 'HEAD'],)
  @39: (['git', 'config', 'branch.hash.last-upload-hash', 'hash'],)

[tandrii(chromium), 2016-06-17 19:06:46]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2016-06-17 19:14:14]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 19:14:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2074233002/20001

[commit-bot: I haz the power, 2016-06-17 19:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 19:17:36]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-06-20 13:26:09]

LGTM

[tandrii(chromium), 2016-06-20 18:29:27]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-06-20 18:29:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2074233002/20001

[commit-bot: I haz the power, 2016-06-20 18:32:49]

Description was changed from

==========
git cl test framework: improve debuggability of expected calls.

R=phajdan.jr@chromium.org
BUG=
==========

to

==========
git cl test framework: improve debuggability of expected calls.

R=phajdan.jr@chromium.org
BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9d20675998f69a...
==========

[commit-bot: I haz the power, 2016-06-20 18:32:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9d20675998f69a...