Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2632)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: dart/tests/compiler/dart2js/compiler_test.dart

Issue 20742002: Clean up error handling. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed errors found during testing. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dart/sdk/lib/_internal/compiler/implementation/warnings.dart ('K') | « dart/tests/compiler/dart2js/analyze_only_test.dart ('k') | dart/tests/compiler/dart2js/deprecated_features_test.dart » ('j') | dart/tests/compiler/dart2js/private_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/compiler/dart2js/compiler_test.dart
diff --git a/dart/tests/compiler/dart2js/compiler_test.dart b/dart/tests/compiler/dart2js/compiler_test.dart
index e9ba0249f19babbdf173302c8d4e855f5598b7df..36116f469f4fd43b54793ab03dfdb48d05e2a62a 100644
--- a/dart/tests/compiler/dart2js/compiler_test.dart
+++ b/dart/tests/compiler/dart2js/compiler_test.dart
@@ -25,9 +25,11 @@ class CallbackMockCompiler extends MockCompiler {
super.reportWarning(node, message);
}
- void reportError(Node node, var message) {
- if (onError != null) onError(this, node, message);
- super.reportError(node, message);
+ void reportError(Spannable node,
+ MessageKind errorCode,
+ [Map arguments = const {}]) {
+ if (onError != null) onError(this, node, errorCode.error(arguments));
+ super.reportError(node, errorCode, arguments);
}
}
« dart/sdk/lib/_internal/compiler/implementation/warnings.dart ('K') | « dart/tests/compiler/dart2js/analyze_only_test.dart ('k') | dart/tests/compiler/dart2js/deprecated_features_test.dart » ('j') | dart/tests/compiler/dart2js/private_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698