Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 20742002: Clean up error handling. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed errors found during testing. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index 9e842070edb20e5032e1a0688ce2bebc4152f172..a82272bdc9b9b269a64f8d0f34c11131f23a01af 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -3028,7 +3028,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
Node argument;
switch (arguments.length) {
case 0:
- compiler.reportErrorCode(
+ compiler.reportError(
node, MessageKind.GENERIC,
{'text': 'Error: Expected one argument to JS_GET_NAME.'});
return;
@@ -3037,7 +3037,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
break;
default:
for (int i = 1; i < arguments.length; i++) {
- compiler.reportErrorCode(
+ compiler.reportError(
arguments[i], MessageKind.GENERIC,
{'text': 'Error: Extra argument to JS_GET_NAME.'});
}
@@ -3045,7 +3045,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
}
LiteralString string = argument.asLiteralString();
if (string == null) {
- compiler.reportErrorCode(
+ compiler.reportError(
argument, MessageKind.GENERIC,
{'text': 'Error: Expected a literal string.'});
}
@@ -3768,7 +3768,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
}
if (Elements.isErroneousElement(element)) {
ErroneousElement error = element;
- if (error.messageKind == MessageKind.CANNOT_FIND_CONSTRUCTOR) {
+ if (error.messageKind == MessageKind.CANNOT_FIND_CONSTRUCTOR.error) {
generateThrowNoSuchMethod(node.send,
getTargetName(error, 'constructor'),
argumentNodes: node.send.arguments);
@@ -4467,16 +4467,18 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
if (firstConstantType == null) {
firstConstantType = constant.computeType(compiler);
if (nonPrimitiveTypeOverridesEquals(constant)) {
- compiler.reportError(match.expression,
- MessageKind.SWITCH_CASE_VALUE_OVERRIDES_EQUALS.error());
+ compiler.reportFatalError(
+ match.expression,
+ MessageKind.SWITCH_CASE_VALUE_OVERRIDES_EQUALS);
failure = true;
}
} else {
DartType constantType =
constant.computeType(compiler);
if (constantType != firstConstantType) {
- compiler.reportError(match.expression,
- MessageKind.SWITCH_CASE_TYPES_NOT_EQUAL.error());
+ compiler.reportFatalError(
+ match.expression,
+ MessageKind.SWITCH_CASE_TYPES_NOT_EQUAL);
failure = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698