dart/tests/compiler/dart2js/private_test.dart - Issue 20742002: Clean up error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tests/compiler/dart2js/private_test.dart

Issue 20742002: Clean up error handling. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Added documentation guide lines. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dart/sdk/lib/_internal/compiler/implementation/warnings.dart ('K') | « dart/tests/compiler/dart2js/patch_test.dart ('k') | dart/tests/compiler/dart2js/resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/tests/compiler/dart2js/private_test.dart

diff --git a/dart/tests/compiler/dart2js/private_test.dart b/dart/tests/compiler/dart2js/private_test.dart

index 3390c9f2ae8336c7cd39aa82c164216c1ad35434..c8918a70f04f470327b9d1370ed3b88fb605ca8c 100644

--- a/dart/tests/compiler/dart2js/private_test.dart

+++ b/dart/tests/compiler/dart2js/private_test.dart

@@ -74,21 +74,22 @@ void analyze(String text, [expectedWarnings]) {

void main() {

// Read from private variable.

- analyze('var value = _privateVariable;', MessageKind.CANNOT_RESOLVE);

+ analyze('var value = _privateVariable;', MessageKind.CANNOT_RESOLVE.warning);

// Write to private variable.

- analyze('_privateVariable = 0;', MessageKind.CANNOT_RESOLVE);

+ analyze('_privateVariable = 0;', MessageKind.CANNOT_RESOLVE.warning);

// Access private function.

- analyze('var value = _privateFunction;', MessageKind.CANNOT_RESOLVE);

+ analyze('var value = _privateFunction;', MessageKind.CANNOT_RESOLVE.warning);

// Call private function.

- analyze('_privateFunction();', MessageKind.CANNOT_RESOLVE);

+ analyze('_privateFunction();', MessageKind.CANNOT_RESOLVE.warning);

// Call unnamed (public) constructor on private class.

- analyze('new _PrivateClass();', MessageKind.CANNOT_RESOLVE);

+ analyze('new _PrivateClass();', MessageKind.CANNOT_RESOLVE.warning);

// Call public constructor on private class.

- analyze('new _PrivateClass.publicConstructor();', MessageKind.CANNOT_RESOLVE);

+ analyze('new _PrivateClass.publicConstructor();',

+ MessageKind.CANNOT_RESOLVE.warning);

// Call private constructor on private class.

analyze('new _PrivateClass._privateConstructor();',

- MessageKind.CANNOT_RESOLVE);

+ MessageKind.CANNOT_RESOLVE.warning);

// Call public getter of private type.

analyze('var value = publicClass.private;');

// Read from private field on private class.

@@ -129,7 +130,7 @@ void main() {

analyze('publicClass = new PublicClass.publicConstructor();');

// Call private constructor on public class.

analyze('publicClass = new PublicClass._privateConstructor();',

- MessageKind.CANNOT_FIND_CONSTRUCTOR);

+ MessageKind.CANNOT_FIND_CONSTRUCTOR.warning);

// Read from private field on public class.

analyze('var value = publicClass._privateField;',

MessageKind.PRIVATE_ACCESS);