Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/typechecker.dart

Issue 20742002: Clean up error handling. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added documentation guide lines. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/typechecker.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/typechecker.dart b/dart/sdk/lib/_internal/compiler/implementation/typechecker.dart
index 5249a6e768f1605a59f42c4c22383764282bac2d..ce2fdb1e16cdd7a6e45878d2802e4f5a8fb71917 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/typechecker.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/typechecker.dart
@@ -237,7 +237,7 @@ class TypeCheckerVisitor extends Visitor<DartType> {
*/
bool checkAssignable(Node node, DartType from, DartType to) {
if (!types.isAssignable(from, to)) {
- reportTypeWarning(node, MessageKind.NOT_ASSIGNABLE,
+ reportTypeWarning(node, MessageKind.NOT_ASSIGNABLE.warning,
{'fromType': from, 'toType': to});
return false;
}
@@ -413,7 +413,7 @@ class TypeCheckerVisitor extends Visitor<DartType> {
{'className': type.name, 'memberName': name});
break;
case MemberKind.GETTER:
- reportTypeWarning(node, MessageKind.MEMBER_NOT_FOUND,
+ reportTypeWarning(node, MessageKind.MEMBER_NOT_FOUND.warning,
{'className': type.name, 'memberName': name});
break;
case MemberKind.SETTER:

Powered by Google App Engine
This is Rietveld 408576698