dart/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart - Issue 20742002: Clean up error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart

Issue 20742002: Clean up error handling. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Added documentation guide lines. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/deferred_load.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/elements/elements.dart » ('j') | dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart b/dart/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart

index ff9595fc2b2a36f490d58de09351b7b409996ac7..67d379222ddf3f95274f248975a47f53ea835abe 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart

@@ -9,7 +9,6 @@ abstract class DiagnosticListener {

void cancel(String reason, {node, token, instruction, element});

// TODO(karlklose): rename log to something like reportInfo.

void log(message);

- // TODO(karlklose): add reportWarning and reportError to this interface.

void internalErrorOnElement(Element element, String message);

void internalError(String message,

@@ -20,8 +19,7 @@ abstract class DiagnosticListener {

void reportMessage(SourceSpan span, Diagnostic message, api.Diagnostic kind);

- // TODO(ahe): Rename to reportError when that method has been removed.

- void reportErrorCode(Spannable node, MessageKind errorCode, [Map arguments]);

+ void reportError(Spannable node, MessageKind errorCode, [Map arguments]);

void reportInfo(Spannable node, MessageKind errorCode, [Map arguments]);