Clean up error handling.

dart/tests/compiler/dart2js/private_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import 'mock_compiler.dart';
 
 import '../../../sdk/lib/_internal/compiler/implementation/source_file.dart';
 import '../../../sdk/lib/_internal/compiler/implementation/dart2jslib.dart'
     hide SourceString;
@@ skipping 56 matching lines @@
                   }
                   ''';
   Uri uri = Uri.parse('src:public');
   compiler.registerSource(uri, source);
   compiler.runCompiler(uri);
   compareWarningKinds(text, expectedWarnings, compiler.warnings);
 }
 
 void main() {
   // Read from private variable.
-  analyze('var value = _privateVariable;', MessageKind.CANNOT_RESOLVE);
+  analyze('var value = _privateVariable;', MessageKind.CANNOT_RESOLVE.warning);
   // Write to private variable.
-  analyze('_privateVariable = 0;', MessageKind.CANNOT_RESOLVE);
+  analyze('_privateVariable = 0;', MessageKind.CANNOT_RESOLVE.warning);
   // Access private function.
-  analyze('var value = _privateFunction;', MessageKind.CANNOT_RESOLVE);
+  analyze('var value = _privateFunction;', MessageKind.CANNOT_RESOLVE.warning);
   // Call private function.
-  analyze('_privateFunction();', MessageKind.CANNOT_RESOLVE);
+  analyze('_privateFunction();', MessageKind.CANNOT_RESOLVE.warning);
 
   // Call unnamed (public) constructor on private class.
-  analyze('new _PrivateClass();', MessageKind.CANNOT_RESOLVE);
+  analyze('new _PrivateClass();', MessageKind.CANNOT_RESOLVE.warning);
   // Call public constructor on private class.
-  analyze('new _PrivateClass.publicConstructor();', MessageKind.CANNOT_RESOLVE);
+  analyze('new _PrivateClass.publicConstructor();', MessageKind.CANNOT_RESOLVE.warning);

[kustermann, 2013/07/27 09:50:29]

long line

[ahe, 2013/07/28 09:05:51]

Done.

   // Call private constructor on private class.
   analyze('new _PrivateClass._privateConstructor();',
-      MessageKind.CANNOT_RESOLVE);
+      MessageKind.CANNOT_RESOLVE.warning);
   // Call public getter of private type.
   analyze('var value = publicClass.private;');
   // Read from private field on private class.
   analyze('var value = publicClass.private._privateField;',
       MessageKind.PRIVATE_ACCESS);
   // Write to private field on private class.
   analyze('publicClass.private._privateField = 0;',
       MessageKind.PRIVATE_ACCESS);
   // Call private getter on private class.
   analyze('var value = publicClass.private._privateGetter;',
@@ skipping 20 matching lines @@
   analyze('var value = publicClass.private.publicMethod;');
   // Call public method on private class.
   analyze('publicClass.private.publicMethod();');
 
   // Call unnamed (public) constructor on public class.
   analyze('publicClass = new PublicClass();');
   // Call public constructor on public class.
   analyze('publicClass = new PublicClass.publicConstructor();');
   // Call private constructor on public class.
   analyze('publicClass = new PublicClass._privateConstructor();',
-      MessageKind.CANNOT_FIND_CONSTRUCTOR);
+      MessageKind.CANNOT_FIND_CONSTRUCTOR.warning);
   // Read from private field on public class.
   analyze('var value = publicClass._privateField;',
       MessageKind.PRIVATE_ACCESS);
   // Write to private field on public class.
   analyze('publicClass._privateField = 0;',
       MessageKind.PRIVATE_ACCESS);
   // Call private getter on public class.
   analyze('var value = publicClass._privateGetter;',
       MessageKind.PRIVATE_ACCESS);
   // Call private setter on public class.
@@ skipping 13 matching lines @@
   // Call public getter on public class.
   analyze('var value = publicClass.publicGetter;');
   // Call public setter on public class.
   analyze('publicClass.publicSetter = 0;');
   // Access public method on public class.
   analyze('var value = publicClass.publicMethod;');
   // Call public method on public class.
   analyze('publicClass.publicMethod();');
 }