Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: telemetry/telemetry/internal/browser/browser.py

Issue 2074183002: [telemetry] Try to print browser logs and capture a screenshot upon story failure (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Add DumpStateUponFailure to _FakeBrowser Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/android/shared_android_state.py ('k') | telemetry/telemetry/internal/story_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/browser/browser.py
diff --git a/telemetry/telemetry/internal/browser/browser.py b/telemetry/telemetry/internal/browser/browser.py
index 6ea47d85a1f6501875244f1b539cb5db7147ea47..7e0196514524dde3e2df55506c1e82b776f89a93 100644
--- a/telemetry/telemetry/internal/browser/browser.py
+++ b/telemetry/telemetry/internal/browser/browser.py
@@ -321,3 +321,18 @@ class Browser(app.App):
@property
def supports_power_metrics(self):
return self._browser_backend.supports_power_metrics
+
+ def DumpStateUponFailure(self):
+ logging.info('*************** BROWSER STANDARD OUTPUT ***************')
+ try: # pylint: disable=broad-except
+ logging.info(self.GetStandardOutput())
+ except Exception:
+ logging.exception('Failed to get browser standard output:')
+ logging.info('*********** END OF BROWSER STANDARD OUTPUT ************')
+
+ logging.info('********************* BROWSER LOG *********************')
+ try: # pylint: disable=broad-except
+ logging.info(self.GetLogFileContents())
+ except Exception:
+ logging.exception('Failed to get browser log:')
+ logging.info('***************** END OF BROWSER LOG ******************')
« no previous file with comments | « telemetry/telemetry/android/shared_android_state.py ('k') | telemetry/telemetry/internal/story_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698