chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc - Issue 2074153002: Pass the ImageDecoder to the ImageFetcher at creation time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc

Issue 2074153002: Pass the ImageDecoder to the ImageFetcher at creation time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move image_fetcher_impl.* to components/image_fetcher Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc ('K') | « chrome/browser/search/suggestions/image_fetcher_impl.cc ('k') | chrome/browser/search/suggestions/suggestions_service_factory.cc » ('j') | components/image_fetcher/image_fetcher_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc

diff --git a/chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc b/chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc

index 57b9416043a2e74ce15e2168542bc9caf86fd8b3..4f823f9db6dc60a59d7c7637c329c6edd62a34d2 100644

--- a/chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc

+++ b/chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc

@@ -13,6 +13,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/test/base/in_process_browser_test.h"

+#include "components/image_fetcher/image_decoder_impl.h"

#include "components/image_fetcher/image_fetcher_delegate.h"

#include "net/test/embedded_test_server/embedded_test_server.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -75,7 +76,9 @@ class ImageFetcherImplBrowserTest : public InProcessBrowserTest {

ImageFetcherImpl* CreateImageFetcher() {

ImageFetcherImpl* fetcher =

- new ImageFetcherImpl(browser()->profile()->GetRequestContext());

+ new ImageFetcherImpl(

+ new suggestions::ImageDecoderImpl(),

+ browser()->profile()->GetRequestContext());

fetcher->SetImageFetcherDelegate(&delegate_);

return fetcher;

}