chrome/browser/search/thumbnail_source.cc - Issue 2074153002: Pass the ImageDecoder to the ImageFetcher at creation time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/thumbnail_source.cc

Issue 2074153002: Pass the ImageDecoder to the ImageFetcher at creation time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments treib@, bauerb@ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search/suggestions/suggestions_service_factory.cc ('k') | chrome/chrome_browser.gypi » ('j') | components/image_fetcher/image_fetcher_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/thumbnail_source.cc

diff --git a/chrome/browser/search/thumbnail_source.cc b/chrome/browser/search/thumbnail_source.cc

index 3d9faef32b4b53f1a03ae22f410e11713bfa2644..7d55a7078e8500ee8b394c4be2074bf64242d593 100644

--- a/chrome/browser/search/thumbnail_source.cc

+++ b/chrome/browser/search/thumbnail_source.cc

@@ -11,10 +11,11 @@

#include "base/message_loop/message_loop.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search/instant_io_context.h"

-#include "chrome/browser/search/suggestions/image_fetcher_impl.h"

+#include "chrome/browser/search/suggestions/image_decoder_impl.h"

#include "chrome/browser/thumbnails/thumbnail_service.h"

#include "chrome/browser/thumbnails/thumbnail_service_factory.h"

#include "chrome/common/url_constants.h"

+#include "components/image_fetcher/image_fetcher_impl.h"

#include "components/suggestions/image_encoder.h"

#include "net/url_request/url_request.h"

#include "ui/gfx/image/image.h"

@@ -30,7 +31,9 @@ ThumbnailSource::ThumbnailSource(Profile* profile, bool capture_thumbnails)

capture_thumbnails_(capture_thumbnails),

weak_ptr_factory_(this) {

image_fetcher_.reset(

- new suggestions::ImageFetcherImpl(profile->GetRequestContext()));

+ new image_fetcher::ImageFetcherImpl(

+ base::MakeUnique<suggestions::ImageDecoderImpl>(),

+ profile->GetRequestContext()));

}

ThumbnailSource::~ThumbnailSource() {