Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: components/image_fetcher/BUILD.gn

Issue 2074153002: Pass the ImageDecoder to the ImageFetcher at creation time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments round2 treib@ & added missing imports *sigh* Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/image_fetcher.gypi ('k') | components/image_fetcher/image_fetcher_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("image_fetcher") { 5 source_set("image_fetcher") {
6 sources = [ 6 sources = [
7 "image_data_fetcher.cc", 7 "image_data_fetcher.cc",
8 "image_data_fetcher.h", 8 "image_data_fetcher.h",
9 "image_decoder.h", 9 "image_decoder.h",
10 "image_fetcher.h", 10 "image_fetcher.h",
11 "image_fetcher_delegate.h", 11 "image_fetcher_delegate.h",
12 "image_fetcher_impl.cc",
13 "image_fetcher_impl.h",
12 ] 14 ]
13 15
14 public_deps = [ 16 public_deps = [
15 "//base", 17 "//base",
16 "//net", 18 "//net",
17 "//url", 19 "//url",
18 ] 20 ]
19 } 21 }
20 22
21 source_set("unit_tests") { 23 source_set("unit_tests") {
22 testonly = true 24 testonly = true
23 sources = [ 25 sources = [
24 "image_data_fetcher_unittest.cc", 26 "image_data_fetcher_unittest.cc",
25 ] 27 ]
26 deps = [ 28 deps = [
27 ":image_fetcher", 29 ":image_fetcher",
28 "//net", 30 "//net",
29 "//net:test_support", 31 "//net:test_support",
30 "//testing/gmock", 32 "//testing/gmock",
31 "//testing/gtest", 33 "//testing/gtest",
32 ] 34 ]
33 } 35 }
OLDNEW
« no previous file with comments | « components/image_fetcher.gypi ('k') | components/image_fetcher/image_fetcher_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698