Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2074103004: Revert of More removal of SkColorProfileType... (Closed)

Created:
4 years, 6 months ago by egdaniel
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of More removal of SkColorProfileType... (patchset #2 id:20001 of https://codereview.chromium.org/2071393002/ ) Reason for revert: This was still used in chrome Original issue's description: > More removal of SkColorProfileType... > > Scrub GMs. Remove the gDefaultProfile thing (it's unused now), along with > the command line flag that was setting it in DM and nanobench. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2071393002 > > Committed: https://skia.googlesource.com/skia/+/944876f2745a62a839e49275daf93a0329372e67 TBR=msarett@google.com,reed@google.com,bsalomon@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/802acec1876bb647aaab1bbcfd97748bba54da8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -49 lines) Patch
M bench/nanobench.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M dm/DM.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M gm/SkLinearBitmapPipelineGM.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M gm/all_bitmap_configs.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M gm/color4f.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M gm/dftext.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/gamma.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/surface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textblobgeometrychange.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/textblobmixedsizes.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M gm/textblobrandomfont.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBitmap.h View 1 chunk +3 lines, -0 lines 0 comments Download
A include/private/SkImageInfoPriv.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkImageInfo.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/SkGr.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
egdaniel
Created Revert of More removal of SkColorProfileType...
4 years, 6 months ago (2016-06-17 22:11:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074103004/1
4 years, 6 months ago (2016-06-17 22:11:32 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 22:11:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/802acec1876bb647aaab1bbcfd97748bba54da8f

Powered by Google App Engine
This is Rietveld 408576698