Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

Issue 2074093003: Fix more corner cases for empty touch selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix type assertion in WebViewTest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
index 151b835f7ea5815b8bc6b3809b654b170a39cdbc..5499a4f29c2f65cde1f4a08600bbce60e5361e01 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
@@ -35,7 +35,7 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
+ "<input id=\"empty_input_text\" type=\"text\" />"
+ "<br/><input id=\"input_text\" type=\"text\" value=\"SampleInputText\" />"
+ "<br/><textarea id=\"textarea\" rows=\"2\" cols=\"20\">SampleTextArea</textarea>"
- + "<br/><input id=\"input_password\" type=\"password\" value=\"SamplePassword\" />"
+ + "<br/><input id=\"password\" type=\"password\" value=\"SamplePassword\" size=\"10\"/>"
yosin_UTC9 2016/06/21 07:50:45 Why do you change id to "password"?
aelias_OOO_until_Jul13 2016/06/21 18:30:41 To fit in Java 100-character line limit. It was t
+ "<br/><p><span id=\"plain_text_1\">SamplePlainTextOne</span></p>"
+ "<br/><p><span id=\"plain_text_2\">SamplePlainTextTwo</span></p>"
+ "<br/><input id=\"disabled_text\" type=\"text\" disabled value=\"Sample Text\" />"
@@ -241,7 +241,7 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
@SmallTest
@Feature({"TextInput"})
public void testActionBarConfiguredCorrectlyForPassword() throws Throwable {
- DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+ DOMUtils.longPressNode(this, mContentViewCore, "password");
waitForSelectActionBarVisible(true);
assertTrue(mContentViewCore.hasSelection());
assertNotNull(mContentViewCore.getSelectActionHandler());
@@ -302,7 +302,7 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
assertNotNull(mContentViewCore.getSelectActionHandler());
selectActionBarCopy();
waitForClipboardContents(mContentViewCore.getContext(), "SamplePlainTextOne");
- DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+ DOMUtils.longPressNode(this, mContentViewCore, "password");
waitForSelectActionBarVisible(true);
assertTrue(mContentViewCore.hasSelection());
assertNotNull(mContentViewCore.getSelectActionHandler());
@@ -359,7 +359,7 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
@Feature({"TextInput"})
public void testSelectActionBarPasswordCut() throws Exception {
copyStringToClipboard("SampleTextToCopy");
- DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+ DOMUtils.longPressNode(this, mContentViewCore, "password");
waitForSelectActionBarVisible(true);
assertTrue(mContentViewCore.hasSelection());
assertNotNull(mContentViewCore.getSelectActionHandler());
@@ -414,7 +414,7 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
@SmallTest
@Feature({"TextInput"})
public void testSelectActionBarPasswordSelectAll() throws Exception {
- DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+ DOMUtils.longPressNode(this, mContentViewCore, "password");
waitForSelectActionBarVisible(true);
assertTrue(mContentViewCore.hasSelection());
assertNotNull(mContentViewCore.getSelectActionHandler());
@@ -522,7 +522,7 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
copyStringToClipboard("SamplePassword2");
// Select the password field.
- DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+ DOMUtils.longPressNode(this, mContentViewCore, "password");
waitForSelectActionBarVisible(true);
assertTrue(mContentViewCore.hasSelection());
assertEquals(mContentViewCore.getSelectedText().length(), "SamplePassword".length());
@@ -537,7 +537,7 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
// Ensure the new text matches the pasted text. Note that we can't
// actually compare strings as password field selections only provide
// a placeholder with the correct length.
- DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+ DOMUtils.longPressNode(this, mContentViewCore, "password");
waitForSelectActionBarVisible(true);
assertTrue(mContentViewCore.hasSelection());
assertEquals(mContentViewCore.getSelectedText().length(), "SamplePassword2".length());

Powered by Google App Engine
This is Rietveld 408576698