Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: components/image_fetcher/image_data_fetcher_unittest.cc

Issue 2074093002: Add a unittest for image_data_fetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use only a single callback object in the FetchImageData_MultipleRequests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/image_fetcher/image_data_fetcher.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/image_fetcher/image_data_fetcher.h"
6
7 #include <memory>
8
9 #include "base/callback.h"
10 #include "base/macros.h"
11 #include "base/memory/ref_counted.h"
12 #include "base/message_loop/message_loop.h"
13 #include "net/url_request/test_url_fetcher_factory.h"
14 #include "net/url_request/url_request_status.h"
15 #include "net/url_request/url_request_test_util.h"
16 #include "testing/gmock/include/gmock/gmock.h"
17 #include "testing/gtest/include/gtest/gtest.h"
18
19 namespace {
20
21 const char kImageURL[] = "http://www.example.com/image";
22 const char kURLResponseData[] = "EncodedImageData";
23
24 } // namespace
25
26 namespace image_fetcher {
27
28 class ImageDataFetcherTest : public testing::Test {
29 public:
30 ImageDataFetcherTest()
31 : test_request_context_getter_(
32 new net::TestURLRequestContextGetter(message_loop_.task_runner())),
33 image_data_fetcher_(test_request_context_getter_.get()) {}
34 ~ImageDataFetcherTest() override {}
35
36 MOCK_METHOD1(OnImageDataFetched, void(const std::string&));
37
38 MOCK_METHOD1(OnImageDataFetchedFailedRequest, void(const std::string&));
39
40 MOCK_METHOD1(OnImageDataFetchedMultipleRequests, void(const std::string&));
41
42 protected:
43 base::MessageLoop message_loop_;
44
45 scoped_refptr<net::URLRequestContextGetter> test_request_context_getter_;
46
47 ImageDataFetcher image_data_fetcher_;
48
49 net::TestURLFetcherFactory fetcher_factory_;
50
51 private:
52 DISALLOW_COPY_AND_ASSIGN(ImageDataFetcherTest);
53 };
54
55 TEST_F(ImageDataFetcherTest, FetchImageData) {
56 image_data_fetcher_.FetchImageData(
57 GURL(kImageURL),
58 base::Bind(&ImageDataFetcherTest::OnImageDataFetched,
59 base::Unretained(this)));
60 EXPECT_CALL(*this, OnImageDataFetched(std::string(kURLResponseData)));
61
62 // Get and configure the TestURLFetcher.
63 net::TestURLFetcher* test_url_fetcher = fetcher_factory_.GetFetcherByID(0);
64 ASSERT_NE(nullptr, test_url_fetcher);
65 test_url_fetcher->set_status(
66 net::URLRequestStatus(net::URLRequestStatus::SUCCESS, net::OK));
67 test_url_fetcher->SetResponseString(kURLResponseData);
68
69 // Call the URLFetcher delegate to continue the test.
70 test_url_fetcher->delegate()->OnURLFetchComplete(test_url_fetcher);
71 }
72
73 TEST_F(ImageDataFetcherTest, FetchImageData_FailedRequest) {
74 image_data_fetcher_.FetchImageData(
75 GURL(kImageURL),
76 base::Bind(&ImageDataFetcherTest::OnImageDataFetchedFailedRequest,
77 base::Unretained(this)));
78 EXPECT_CALL(*this, OnImageDataFetchedFailedRequest(std::string()));
79
80 // Get and configure the TestURLFetcher.
81 net::TestURLFetcher* test_url_fetcher = fetcher_factory_.GetFetcherByID(0);
82 ASSERT_NE(nullptr, test_url_fetcher);
83 test_url_fetcher->set_status(
84 net::URLRequestStatus(net::URLRequestStatus::FAILED,
85 net::ERR_INVALID_URL));
86
87 // Call the URLFetcher delegate to continue the test.
88 test_url_fetcher->delegate()->OnURLFetchComplete(test_url_fetcher);
89 }
90
91 TEST_F(ImageDataFetcherTest, FetchImageData_MultipleRequests) {
92 ImageDataFetcher::ImageDataFetcherCallback callback =
93 base::Bind(&ImageDataFetcherTest::OnImageDataFetchedMultipleRequests,
94 base::Unretained(this));
95 EXPECT_CALL(*this, OnImageDataFetchedMultipleRequests(testing::_)).Times(2);
96
97 image_data_fetcher_.FetchImageData(GURL(kImageURL), callback);
98 image_data_fetcher_.FetchImageData(GURL(kImageURL), callback);
99
100 // Multiple calls to FetchImageData for the same URL will result in
101 // multiple URLFetchers being created.
102 net::TestURLFetcher* test_url_fetcher = fetcher_factory_.GetFetcherByID(0);
103 ASSERT_NE(nullptr, test_url_fetcher);
104 test_url_fetcher->delegate()->OnURLFetchComplete(test_url_fetcher);
105
106 test_url_fetcher = fetcher_factory_.GetFetcherByID(1);
107 ASSERT_NE(nullptr, test_url_fetcher);
108 test_url_fetcher->delegate()->OnURLFetchComplete(test_url_fetcher);
109 }
110
111 } // namespace image_fetcher
OLDNEW
« no previous file with comments | « components/image_fetcher/image_data_fetcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698