chrome/browser/resources/settings/settings_ui/settings_ui.js - Issue 2074063003: MD Settings: Migrate from paper-drawer-panel to app-drawer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2074063003: MD Settings: Migrate from paper-drawer-panel to app-drawer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing RTL issue. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_ui/settings_ui.html ('K') | « chrome/browser/resources/settings/settings_ui/settings_ui.html ('k') | chrome/test/data/webui/settings/rtl_tests.js » ('j') | ui/webui/resources/polymer_resources.grdp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_ui/settings_ui.js

diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js

index f963adaa2ab6d45e5fed845944a5a9269c47c1ba..c27a0baf305cfb4383ed57cd2c5e52908d947f8f 100644

--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js

+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js

@@ -33,11 +33,16 @@ Polymer({

/** @private */

onIronActivate_: function() {

- this.$.panel.closeDrawer();

+ this.$$('app-drawer').close();

/** @private */

directionDelegateChanged_: function() {

- this.$.panel.rightDrawer = this.directionDelegate.isRtl();

+ this.$$('app-drawer').align = this.directionDelegate.isRtl() ?

+ 'right' : 'left';

+ },

+ onMenuButtonTap_: function() {

michaelpg 2016/06/20 19:43:59 opt nit: move up to group onEvent fns together

michaelpg 2016/06/20 19:43:59 private

dpapad 2016/06/20 20:27:31 Done.

+ this.$$('app-drawer').toggle();

});