Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2074063003: MD Settings: Migrate from paper-drawer-panel to app-drawer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing RTL issue. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-ui' implements the UI for the Settings page. 7 * 'settings-ui' implements the UI for the Settings page.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 15 matching lines...) Expand all
26 type: Object, 26 type: Object,
27 }, 27 },
28 }, 28 },
29 29
30 listeners: { 30 listeners: {
31 'sideNav.iron-activate': 'onIronActivate_', 31 'sideNav.iron-activate': 'onIronActivate_',
32 }, 32 },
33 33
34 /** @private */ 34 /** @private */
35 onIronActivate_: function() { 35 onIronActivate_: function() {
36 this.$.panel.closeDrawer(); 36 this.$$('app-drawer').close();
37 }, 37 },
38 38
39 /** @private */ 39 /** @private */
40 directionDelegateChanged_: function() { 40 directionDelegateChanged_: function() {
41 this.$.panel.rightDrawer = this.directionDelegate.isRtl(); 41 this.$$('app-drawer').align = this.directionDelegate.isRtl() ?
42 'right' : 'left';
43 },
44
45 onMenuButtonTap_: function() {
michaelpg 2016/06/20 19:43:59 opt nit: move up to group onEvent fns together
michaelpg 2016/06/20 19:43:59 private
dpapad 2016/06/20 20:27:31 Done.
46 this.$$('app-drawer').toggle();
42 }, 47 },
43 }); 48 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698