Issue 2073993002: Don't use selection bounds to paint document marker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2073993002: Don't use selection bounds to paint document marker (Closed)

Created:
4 years, 6 months ago by Xianzhu

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't use selection bounds to paint document marker If there is no selection, selection bounds may exceed the paint invalidation rect. The original reason of using selection bounds to paint document marker "when the selection and this highlight are on the same word there are no pieces sticking out" no longer applies because we don't allow selection and document markers at the same time. BUG=619633 Review-Url: https://codereview.chromium.org/2065723002 Cr-Commit-Position: refs/heads/master@{#400080}

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp	View		2 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

4 years, 6 months ago (2016-06-17 02:40:29 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
eeae91327432a677457fc1d2d0805c4dccef6ae2.

Expand Messages | Collapse Messages