scripts/slave/recipe_modules/chromium_tests/steps.py - Issue 2073923002: Support sharding for swarmed isolated script tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 2073923002: Support sharding for swarmed isolated script tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Explicitly handle missing shards' output. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium_tests/steps.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py

index c338bf91f86f609e47c7510ea59b7c0485b8364a..b9cf0943d6d884cdf51697268719496dce23145e 100644

--- a/scripts/slave/recipe_modules/chromium_tests/steps.py

+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py

@@ -1226,7 +1226,7 @@ class SwarmingIsolatedScriptTest(SwarmingTest):

# TODO(nednguyen): make this configurable in isolated_scripts's spec.

return api.swarming.isolated_script_task(

title=self._step_name(suffix), isolated_hash=isolated_hash,

- idempotent=False, extra_args=args)

+ shards=self._shards, idempotent=False, extra_args=args)

def validate_task_results(self, api, step_result):

results = getattr(step_result, 'isolated_script_results', None) or {}

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/swarming/api.py » ('j') | no next file with comments »