Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2073903002: Storage manager: Add browsing data. (Closed)

Created:
4 years, 6 months ago by fukino
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, msramek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Storage manager: Add browsing data. This CL adds following functions: - Show the roughly estimated size of browsing data. - Provide a link to open up "Clear browsing data" overlay. BUG=591958 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/95e7ad5a70a16f42561b9ccd90c764d2d8becb97 Cr-Commit-Position: refs/heads/master@{#402093}

Patch Set 1 #

Patch Set 2 : Storage manager: Add browsing data. #

Patch Set 3 : Fix a minor issue on closure annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.js View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc View 1 5 chunks +37 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
fukino
PTAL. Sorry for interrupting you by frequent CLs! Some more will come... I haven't implemented ...
4 years, 6 months ago (2016-06-17 02:21:46 UTC) #3
fukino
Oops, we can't use BrowsingDataCounter since it has a preference check. I'll take alternative way ...
4 years, 6 months ago (2016-06-17 03:23:28 UTC) #4
fukino
4 years, 6 months ago (2016-06-17 03:23:37 UTC) #6
fukino
Dan, could you take a look? I'll add the size of site data after https://codereview.chromium.org/2092663002/.
4 years, 6 months ago (2016-06-23 20:58:57 UTC) #9
Dan Beam
lgtm
4 years, 6 months ago (2016-06-25 00:43:43 UTC) #10
fukino
Thank you!
4 years, 5 months ago (2016-06-27 00:02:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2073903002/20001
4 years, 5 months ago (2016-06-27 00:02:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/690)
4 years, 5 months ago (2016-06-27 00:14:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2073903002/40001
4 years, 5 months ago (2016-06-27 00:42:54 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-27 01:19:17 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 01:20:49 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95e7ad5a70a16f42561b9ccd90c764d2d8becb97
Cr-Commit-Position: refs/heads/master@{#402093}

Powered by Google App Engine
This is Rietveld 408576698