runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart - Issue 2073893002: Removed all analyzer issues from tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart

Issue 2073893002: Removed all analyzer issues from tests (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/dev_fs_test.dart ('k') | runtime/observatory/tests/service/evaluate_activation_in_method_class_test.dart » ('j') | runtime/observatory/tests/service/get_isolate_after_stack_overflow_error_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart

diff --git a/runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart b/runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart

index 6cc5879e94d16eeee8f71dfcb817cac88faf7170..0b82dadfa0253f2bc67100da20d95c79abd86295 100644

--- a/runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart

+++ b/runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart

@@ -11,6 +11,7 @@ class Superclass {

var instVar = 'Superclass';

method() => 'Superclass';

static staticMethod() => 'Superclass';

+ suppress_warning() => _instVar;

}

class Klass extends Superclass {

@@ -22,5 +23,7 @@ class Klass extends Superclass {

test() {

var _local = 'Klass';

debugger();

+ //suppress warning

Cutch 2016/06/16 21:38:22 We always start our comments with a space after th

cbernaschina 2016/06/16 21:50:21 Done.

+ print(_local);

}