Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(308)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: runtime/observatory/.analysis_options
Issue
2073893002
:
Removed all analyzer issues from tests (Closed)
Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set:
Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
runtime/observatory/.analysis_options
runtime/observatory/lib/src/debugger/debugger_location.dart
runtime/observatory/lib/src/service/object.dart
runtime/observatory/tests/service/dev_fs_test.dart
runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart
runtime/observatory/tests/service/evaluate_activation_in_method_class_test.dart
runtime/observatory/tests/service/get_isolate_after_language_error_test.dart
runtime/observatory/tests/service/get_isolate_after_out_of_memory_error_test.dart
runtime/observatory/tests/service/get_isolate_after_stack_overflow_error_test.dart
runtime/observatory/tests/service/get_object_store_rpc_test.dart
runtime/observatory/tests/service/instance_field_order_rpc_test.dart
runtime/observatory/tests/service/pause_idle_isolate_test.dart
runtime/observatory/tests/service/pause_on_exceptions_test.dart
runtime/observatory/tests/service/set_name_rpc_test.dart
runtime/observatory/tests/service/test_helper.dart
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
runtime/observatory/lib/src/debugger/debugger_location.dart »
('j') |
runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 analyzer:
1 analyzer:
2 exclude:
2 exclude:
3
# Remove once Dart 1.13-dev is released
3
- tests/service/get_isolate_after_language_error_test.dart
4 - tests/service/developer_extension_test.dart
4 - tests/service/developer_extension_test.dart
5
# Remove once Dart 1.13-dev is released
5
- tests/service/address_mapper_test.dart
6
- tests/service/logging_test.dart
6
- tests/service/pause_on_unhandled_exceptions_test.dart
7
- tests/ui/log.dart
8
# Remove once Dart 1.13-dev is released
9
- tests/service/get_stack_rpc_test.dart
OLD
NEW
« no previous file with comments
|
« no previous file
|
runtime/observatory/lib/src/debugger/debugger_location.dart »
('j') |
runtime/observatory/tests/service/evaluate_activation_in_method_class_other.dart »
('J')
Issue 2073893002: Removed all analyzer issues from tests (Closed)
Created 4 years, 6 months ago by cbernaschina
Modified 4 years, 6 months ago
Reviewers: turnidge, Cutch, rmacnak
Base URL: https://github.com/dart-lang/sdk.git@master
Comments: 17
This is Rietveld
408576698