Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Unified Diff: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_chromeos_unittest.cc

Issue 207383004: Adds a new removable storage provider for imageWriterPrivate on Chrome OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some more test refactoring. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_chromeos_unittest.cc
diff --git a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_chromeos_unittest.cc b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_chromeos_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7ea963cde63d889e3aef0d6c50f17d6e6dd84f64
--- /dev/null
+++ b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_chromeos_unittest.cc
@@ -0,0 +1,154 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/bind.h"
+#include "chrome/browser/extensions/api/image_writer_private/removable_storage_provider.h"
+#include "chromeos/disks/mock_disk_mount_manager.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+namespace {
+
+using namespace chromeos::disks;
+using namespace api::image_writer_private;
+
+const char kDevicePathUSB[] = "/dev/test-usb";
+const char kDevicePathSD[] = "/dev/test-sd";
+const char kMountPath[] = "/test-mount";
+const char kDeviceId[] = "FFFF-FFFF";
+const char kDeviceName[] = "Test Device Name";
+const char kVendorName[] = "Test Vendor";
+const char kProductName[] = "Test Product";
+const uint64 kDeviceSize = 1024 * 1024 * 1024;
+
+const char kUnknownSDDiskModel[] = "SD Card";
+const char kUnknownUSBDiskModel[] = "USB Drive";
+
+class RemovableStorageProviderChromeOsUnitTest : public testing::Test {
+ public:
+ virtual void SetUp() OVERRIDE {
+ disk_mount_manager_mock_ = new MockDiskMountManager();
+ DiskMountManager::InitializeForTesting(disk_mount_manager_mock_);
+ disk_mount_manager_mock_->SetupDefaultReplies();
+ }
+
+ virtual void TearDown() OVERRIDE { DiskMountManager::Shutdown(); }
+
+ void DevicesCallback(scoped_refptr<StorageDeviceList> devices, bool success) {
+ devices_ = devices;
+ }
+
+ void CreateDisk(const std::string& device_path,
+ chromeos::DeviceType device_type,
+ bool is_parent,
+ bool has_media,
+ bool on_boot_device) {
+ return CreateDisk(device_path,
+ kVendorName,
+ kProductName,
+ device_type,
+ is_parent,
+ has_media,
+ on_boot_device);
+ }
+
+ void CreateDisk(const std::string& device_path,
+ const std::string& vendor_name,
+ const std::string& product_name,
+ chromeos::DeviceType device_type,
+ bool is_parent,
+ bool has_media,
+ bool on_boot_device) {
+ DiskMountManager::MountPointInfo mount_info(
+ device_path,
+ kMountPath,
+ chromeos::MOUNT_TYPE_DEVICE,
+ chromeos::disks::MOUNT_CONDITION_NONE);
+ disk_mount_manager_mock_->CreateDiskEntryForMountDevice(mount_info,
+ kDeviceId,
+ kDeviceName,
+ vendor_name,
+ product_name,
+ device_type,
+ kDeviceSize,
+ is_parent,
+ has_media,
+ on_boot_device);
+ }
+
+ // Checks if the DeviceList has a specific entry.
+ RemovableStorageDevice* FindDevice(StorageDeviceList* list,
+ const std::string& file_path) {
+ for (std::vector<linked_ptr<RemovableStorageDevice> >::const_iterator iter =
+ list->data.begin();
+ iter != list->data.end();
+ ++iter) {
+ if ((*iter)->storage_unit_id == file_path) {
+ return (*iter).get();
+ }
+ }
+ return NULL;
+ }
+
+ void ExpectDevice(StorageDeviceList* list,
+ const std::string& device_path,
+ const std::string& vendor,
+ const std::string& model,
+ uint64 capacity) {
+ RemovableStorageDevice* device = FindDevice(devices_, device_path);
+
+ ASSERT_TRUE(device != NULL);
+
+ EXPECT_EQ(device_path, device->storage_unit_id);
+ EXPECT_EQ(vendor, device->vendor);
+ EXPECT_EQ(model, device->model);
+ EXPECT_EQ(capacity, device->capacity);
+ }
+
+ MockDiskMountManager* disk_mount_manager_mock_;
+ scoped_refptr<StorageDeviceList> devices_;
+};
+
+} // namespace
+
+// Tests that GetAllDevices works as expected, only exposing USB and SD cards
+// that are parents, have media and are not boot devices. Other flags are
+// uninteresting or should not occur for these device types.
+TEST_F(RemovableStorageProviderChromeOsUnitTest, GetAllDevices) {
+ CreateDisk(kDevicePathUSB, chromeos::DEVICE_TYPE_USB, true, true, false);
+ CreateDisk(kDevicePathSD, chromeos::DEVICE_TYPE_SD, true, true, false);
+ CreateDisk("/dev/NotParent", chromeos::DEVICE_TYPE_USB, false, true, false);
+ CreateDisk("/dev/NoMedia", chromeos::DEVICE_TYPE_USB, true, false, false);
+ CreateDisk("/dev/OnBootDevice", chromeos::DEVICE_TYPE_USB, true, true, true);
+
+ RemovableStorageProvider::GetAllDevices(
+ base::Bind(&RemovableStorageProviderChromeOsUnitTest::DevicesCallback,
+ base::Unretained(this)));
+
+ ASSERT_EQ(2U, devices_->data.size());
+
+ ExpectDevice(
+ devices_, kDevicePathUSB, kVendorName, kProductName, kDeviceSize);
+ ExpectDevice(devices_, kDevicePathSD, kVendorName, kProductName, kDeviceSize);
+}
+
+// Tests that a USB drive with an empty vendor and product gets a generic name.
+TEST_F(RemovableStorageProviderChromeOsUnitTest, EmptyProductAndModel) {
+ CreateDisk(
+ kDevicePathUSB, "", "", chromeos::DEVICE_TYPE_USB, true, true, false);
+ CreateDisk(
+ kDevicePathSD, "", "", chromeos::DEVICE_TYPE_SD, true, true, false);
+
+ RemovableStorageProvider::GetAllDevices(
+ base::Bind(&RemovableStorageProviderChromeOsUnitTest::DevicesCallback,
+ base::Unretained(this)));
+
+ ASSERT_EQ(2U, devices_->data.size());
+
+ ExpectDevice(devices_, kDevicePathUSB, "", kUnknownUSBDiskModel, kDeviceSize);
+ ExpectDevice(devices_, kDevicePathSD, "", kUnknownSDDiskModel, kDeviceSize);
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698