Adds a new removable storage provider for imageWriterPrivate on Chrome OS

chromeos/disks/mock_disk_mount_manager.h

Index: chromeos/disks/mock_disk_mount_manager.h
diff --git a/chromeos/disks/mock_disk_mount_manager.h b/chromeos/disks/mock_disk_mount_manager.h
index ef3967be06f45fa59de194ae9119bee14c5fca08..077513361dbf006c8cb06e450b22d8c701928c7c 100644
--- a/chromeos/disks/mock_disk_mount_manager.h
+++ b/chromeos/disks/mock_disk_mount_manager.h
@@ -67,6 +67,12 @@ class MockDiskMountManager : public DiskMountManager {
   void RemoveDiskEntryForMountDevice(
       const DiskMountManager::MountPointInfo& mount_info);
 
+  // Adds a fake disk entry.  This takes ownership of the pointer.

[hashimoto, 2014/03/24 04:37:09]

You should use scoped_ptr instead of having this kind of comment.
http://www.chromium.org/developers/smart-pointer-guidelines

[Drew Haven, 2014/03/24 22:33:25]

Done.

+  void AddDiskEntry(Disk* disk);

[tbarzic, 2014/03/22 02:01:02]

you can use CreateDiskEntryForMountDevice/RemoveDiskEntryForMountDevice (with
extra arguments that you need) instead creating new methods that essentially do
the same thing.

[hashimoto, 2014/03/24 04:37:09]

+1

[Drew Haven, 2014/03/24 22:33:25]

The reason I wanted this was because many of the parameters that are set by
CreateDiskEntryForMountDevice are fixed and I wanted to do a more precise test
to be sure that we really only list the devices we expect, e.g. combinations of
hidden, non-parent, and os-devices.

This might be a bit too much of a characterization test and duplicating
application logic in a test, but I wanted to be sure we were doing what we
expected in this case.

If you think it's really over-specifying things, I can remove these functions
and just fall back to using one major positive-case.

[tbarzic, 2014/03/24 22:48:42]

What I had in mind was to change 
CreateDiskEntryForMountDevice(<current_args>)
to
CreateDiskEntryForMountDevice(<current_args>, is_parent, has_media,
on_boot_device), so it can set the values you need.

+
+  // Removes a fake disk entry.  This will delete the pointer.
+  void RemoveDiskEntry(Disk* disk);

[hashimoto, 2014/03/24 04:37:09]

Why don't you pass device_path to this method?

[Drew Haven, 2014/03/24 22:33:25]

Done.

+
  private:
   // Is used to implement AddObserver.
   void AddObserverInternal(DiskMountManager::Observer* observer);