Adds a new removable storage provider for imageWriterPrivate on Chrome OS

chromeos/disks/mock_disk_mount_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/disks/mock_disk_mount_manager.h"
 
 #include <utility>
 
 #include "base/message_loop/message_loop.h"
 #include "base/stl_util.h"
@@ skipping 163 matching lines @@
       .Times(AnyNumber());
 }
 
 void MockDiskMountManager::CreateDiskEntryForMountDevice(
     const DiskMountManager::MountPointInfo& mount_info,
     const std::string& device_id,
     const std::string& device_label,
     const std::string& vendor_name,
     const std::string& product_name,
     DeviceType device_type,
-    uint64 total_size_in_bytes) {
+    uint64 total_size_in_bytes,
+    bool is_parent,
+    bool has_media,
+    bool on_boot_device) {
   Disk* disk = new DiskMountManager::Disk(std::string(mount_info.source_path),

[hashimoto, 2014/03/27 02:22:40]

nit: std::string(...) is unnecessary.
No need to convert std::string to std::string manually.

[Drew Haven, 2014/03/27 19:31:12]

That was there before, so I just left it.  Might as well clean it up and improve
the code base!

                                           std::string(mount_info.mount_path),

[hashimoto, 2014/03/27 02:22:40]

ditto.

[Drew Haven, 2014/03/27 19:31:12]

Done.

                                           std::string(),  // system_path
-                                          std::string(),  // file_path
-                                          device_label,  // device_label
+                                          std::string(mount_info.source_path),

[hashimoto, 2014/03/27 02:22:40]

ditto.

[Drew Haven, 2014/03/27 19:31:12]

Done.

+                                          device_label,   // device_label

[hashimoto, 2014/03/27 02:22:40]

nit: > "// device label"
This kind of comment may be meaningful for the fields filled with std::string(),
but not for fields like this.

[Drew Haven, 2014/03/27 19:31:12]

Done.

                                           std::string(),  // drive_label
                                           std::string(),  // vendor_id
                                           vendor_name,
                                           std::string(),  // product_id
                                           product_name,
-                                          device_id,  // fs_uuid
+                                          device_id,      // fs_uuid
                                           std::string(),  // system_path_prefix
                                           device_type,
                                           total_size_in_bytes,
-                                          false,  // is_parent
-                                          false,  // is_read_only
-                                          true,  // has_media
-                                          false,  // on_boot_device
-                                          false);  // is_hidden
+                                          is_parent,       // is_parent
+                                          false,           // is_read_only
+                                          has_media,       // has_media
+                                          on_boot_device,  // on_boot_device

[hashimoto, 2014/03/27 02:22:40]

ditto for these four fields.

[Drew Haven, 2014/03/27 19:31:12]

Done.

+                                          false);          // is_hidden
   DiskMountManager::DiskMap::iterator it = disks_.find(mount_info.source_path);
   if (it == disks_.end()) {
     disks_.insert(std::make_pair(std::string(mount_info.source_path), disk));
   } else {
     delete it->second;
     it->second = disk;
   }
 }
 
 void MockDiskMountManager::RemoveDiskEntryForMountDevice(
@@ skipping 23 matching lines @@
   FOR_EACH_OBSERVER(Observer, observers_, OnDiskEvent(event, disk));
 }
 
 void MockDiskMountManager::NotifyDeviceChanged(DeviceEvent event,
                                                const std::string& path) {
   FOR_EACH_OBSERVER(Observer, observers_, OnDeviceEvent(event, path));
 }
 
 }  // namespace disks
 }  // namespace chromeos