Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 20738002: Make DOMImplementation::hasFeature() behave according to specification (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, lgombos
Visibility:
Public.

Description

Make DOMImplementation::hasFeature() behave according to specification Make DOMImplementation::hasFeature() behave according to the latest specification: http://dom.spec.whatwg.org/#dom-domimplementation-hasfeature Specifically, the function now returns true unconditionally for any non-SVG feature. This behavior is consistent with Firefox. hasFeature() originally would report whether the user agent claimed to support a given DOM feature, but experience proved it was not nearly as reliable or granular as simply checking whether the desired interfaces, attributes, or methods existed. As such, it should no longer be used, but continues to exist (and simply returns true) so that old pages don't stop working. BUG=264683 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155050

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebaseline conformance test instead of fixing it #

Patch Set 3 : Use [ NeedsRebaseline ] for the 2 pixels tests #

Patch Set 4 : Without the binaries so that the try bots are happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -214 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/hasFeature01-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/hasFeature02-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/hasFeature03-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/hasFeature04-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/dom/features-expected.txt View 6 chunks +81 lines, -81 lines 0 comments Download
M LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/svg/custom/outer-svg-unknown-feature.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGCircleElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGEllipseElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGForeignObjectElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGGElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGGElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGImageElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGImageElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGPathElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGPathElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGPolygonElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGPolygonElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGPolylineElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGPolylineElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGRectElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGRectElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGSVGElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGSVGElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGTextElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGUseElement-dom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dynamic-updates/script-tests/SVGUseElement-svgdom-requiredFeatures.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 4 chunks +9 lines, -69 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-26 14:23:19 UTC) #1
Stephen Chennney
I'm fine with the SVG portions.
7 years, 5 months ago (2013-07-26 14:37:38 UTC) #2
abarth-chromium
Code change LGTM. I'm not sure about modifying the SVG conformance test... https://codereview.chromium.org/20738002/diff/1/LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f.svg File LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f.svg ...
7 years, 5 months ago (2013-07-26 17:24:25 UTC) #3
do-not-use
https://codereview.chromium.org/20738002/diff/1/LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f.svg File LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f.svg (left): https://codereview.chromium.org/20738002/diff/1/LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f.svg#oldcode64 LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f.svg:64: if(i1 != "this.is.a.bogus.feature.string") On 2013/07/26 17:24:25, abarth wrote: > ...
7 years, 5 months ago (2013-07-26 17:49:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/20738002/18001
7 years, 5 months ago (2013-07-27 09:21:35 UTC) #5
commit-bot: I haz the power
Change committed as 155050
7 years, 4 months ago (2013-07-27 12:23:31 UTC) #6
arv (Not doing code reviews)
7 years, 4 months ago (2013-07-30 20:08:25 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698