Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2073793002: Rename fxmath_barcodeimp to cfx_barcode (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename fxmath_barcodeimp to cfx_barcode Renames the files to make their contents clearer. Committed: https://pdfium.googlesource.com/pdfium/+/8320ee28f24615d1d619a5db1b7c235ea6f91dde

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -449 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M xfa.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + xfa/fwl/basewidget/cfx_barcode.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/fwl/basewidget/cfx_barcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
D xfa/fwl/basewidget/fxmath_barcodeimp.h View 1 chunk +0 lines, -63 lines 0 comments Download
D xfa/fwl/basewidget/fxmath_barcodeimp.cpp View 1 chunk +0 lines, -377 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL. I have no idea why these are fxmath_ they are the only files with ...
4 years, 6 months ago (2016-06-16 15:14:14 UTC) #2
Wei Li
lgtm https://codereview.chromium.org/2073793002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2073793002/diff/1/BUILD.gn#newcode1021 BUILD.gn:1021: "xfa/fwl/basewidget/cfx_barcode.cpp", Move to be in alphabetical order? https://codereview.chromium.org/2073793002/diff/1/xfa.gyp ...
4 years, 6 months ago (2016-06-16 16:50:12 UTC) #3
dsinclair
https://codereview.chromium.org/2073793002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2073793002/diff/1/BUILD.gn#newcode1021 BUILD.gn:1021: "xfa/fwl/basewidget/cfx_barcode.cpp", On 2016/06/16 16:50:12, Wei Li wrote: > Move ...
4 years, 6 months ago (2016-06-16 17:41:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073793002/20001
4 years, 6 months ago (2016-06-16 17:41:28 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 18:01:22 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8320ee28f24615d1d619a5db1b7c235ea6f9...

Powered by Google App Engine
This is Rietveld 408576698