Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2073753003: Convert ios_web_shell to ARC. (Closed)

Created:
4 years, 6 months ago by stkhapugin
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@buildconfig-gn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ios_web_shell to ARC. Converts ios_web_shell target to use Automatic Reference Counting. BUG=None Committed: https://crrev.com/35107e0087ce9ad06d30d2913a14f30991b8d5a7 Cr-Commit-Position: refs/heads/master@{#400669}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M ios/web/ios_web_shell_exe.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/shell/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ios/web/shell/app_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/shell/app_delegate.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/shell_browser_state.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/shell_main_delegate.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/shell_url_request_context_getter.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/shell_web_client.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/shell_web_main_parts.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/shell/view_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/shell/view_controller.mm View 5 chunks +5 lines, -6 lines 0 comments Download
M ios/web/shell/web_exe_main.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
stkhapugin
PTAL. Note that I will send a PSA explaining that the conversion has started and ...
4 years, 6 months ago (2016-06-16 13:51:44 UTC) #2
rohitrao (ping after 24h)
Is this something we can sit together and look at on Monday, or do you ...
4 years, 6 months ago (2016-06-16 13:52:40 UTC) #3
rohitrao (ping after 24h)
The code itself LGTM, but I'd like to discuss the overall process.
4 years, 6 months ago (2016-06-16 13:53:56 UTC) #4
stkhapugin
On 2016/06/16 13:53:56, rohitrao wrote: > The code itself LGTM, but I'd like to discuss ...
4 years, 6 months ago (2016-06-16 13:55:08 UTC) #5
sdefresne
lgtm
4 years, 6 months ago (2016-06-16 14:03:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073753003/20001
4 years, 6 months ago (2016-06-20 12:40:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 13:45:50 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 13:48:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35107e0087ce9ad06d30d2913a14f30991b8d5a7
Cr-Commit-Position: refs/heads/master@{#400669}

Powered by Google App Engine
This is Rietveld 408576698