Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2073753002: Simplify the ImageDataFetcher code. (Closed)

Created:
4 years, 6 months ago by markusheintz_
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify the ImageDataFetcher code. BUG=609127 Committed: https://crrev.com/1241847a73db4ccc2e37240b3c5c92c04d3be3ae Cr-Commit-Position: refs/heads/master@{#400642}

Patch Set 1 #

Patch Set 2 : '"' #

Total comments: 1

Patch Set 3 : Address comments treib@ #

Patch Set 4 : Sync to tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -72 lines) Patch
M components/image_fetcher/image_data_fetcher.h View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M components/image_fetcher/image_data_fetcher.cc View 1 2 3 chunks +30 lines, -65 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
markusheintz_
On 2016/06/16 11:44:34, markusheintz_ wrote: > mailto:markusheintz@chromium.org changed reviewers: > + mailto:bauerb@chromium.org, mailto:treib@chromium.org This is ...
4 years, 6 months ago (2016-06-16 11:45:01 UTC) #3
Marc Treib
lgtm https://codereview.chromium.org/2073753002/diff/20001/components/image_fetcher/image_data_fetcher.cc File components/image_fetcher/image_data_fetcher.cc (right): https://codereview.chromium.org/2073753002/diff/20001/components/image_fetcher/image_data_fetcher.cc#newcode34 components/image_fetcher/image_data_fetcher.cc:34: url_fetcher(std::move(url_fetcher)) { optional: You could just inline this ...
4 years, 6 months ago (2016-06-16 11:52:09 UTC) #4
Bernhard Bauer
lgtm
4 years, 6 months ago (2016-06-16 13:45:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073753002/60001
4 years, 6 months ago (2016-06-20 09:18:26 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-20 10:19:32 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 10:21:09 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1241847a73db4ccc2e37240b3c5c92c04d3be3ae
Cr-Commit-Position: refs/heads/master@{#400642}

Powered by Google App Engine
This is Rietveld 408576698