Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2073713003: [tools/perf] Keep both browsers open from the start of dual browser test (Closed)

Created:
4 years, 6 months ago by perezju
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Keep both browsers open from the start of dual browser test At the start of the story set, open the browsers associated with all stories. This makes sure that, when taking memory dumps, we always get a dump for all browsers all the time. BUG=616043 Committed: https://crrev.com/f41edc4cf5d1b086ad00d70bf9fcb51d3fe9183e Cr-Commit-Position: refs/heads/master@{#400667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/perf/page_sets/dual_browser_story.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
perezju
4 years, 6 months ago (2016-06-16 15:54:11 UTC) #2
nednguyen
lgtm
4 years, 6 months ago (2016-06-16 17:04:12 UTC) #3
Primiano Tucci (use gerrit)
lgtm
4 years, 6 months ago (2016-06-17 07:38:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073713003/1
4 years, 6 months ago (2016-06-20 12:15:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 13:21:22 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f41edc4cf5d1b086ad00d70bf9fcb51d3fe9183e Cr-Commit-Position: refs/heads/master@{#400667}
4 years, 6 months ago (2016-06-20 13:22:46 UTC) #9
perezju
4 years, 6 months ago (2016-06-22 12:00:23 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2084393002/ by perezju@chromium.org.

The reason for reverting is: Broke WPR on the benchmark.

Powered by Google App Engine
This is Rietveld 408576698