Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: chrome/browser/safe_browsing/permission_reporter.cc

Issue 2073713002: Add field trials and platform to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation
Patch Set: Move typedef ActiveGroupIdSet Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/permission_reporter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/permission_reporter.cc
diff --git a/chrome/browser/safe_browsing/permission_reporter.cc b/chrome/browser/safe_browsing/permission_reporter.cc
index b64f60ceff6ea32b265873919d5740b8253b4819..944411149f1a9480811bc0dee25489cde61da453 100644
--- a/chrome/browser/safe_browsing/permission_reporter.cc
+++ b/chrome/browser/safe_browsing/permission_reporter.cc
@@ -5,6 +5,7 @@
#include "base/memory/ptr_util.h"
#include "chrome/browser/safe_browsing/permission_reporter.h"
#include "chrome/common/safe_browsing/permission_report.pb.h"
+#include "components/variations/active_field_trials.h"
#include "content/public/browser/permission_type.h"
#include "net/url_request/report_sender.h"
@@ -103,8 +104,25 @@ bool PermissionReporter::BuildReport(const GURL& origin,
report.set_origin(origin.spec());
report.set_permission(PermissionTypeForReport(permission));
report.set_action(PermissionActionForReport(action));
- // TODO(stefanocs): Collect field trials and platform type from global
- // variables to the permission report.
+
+ // Collect platform data.
+#if defined(OS_ANDROID)
+ report.set_platform_type(PermissionReport::ANDROID_PLATFORM);
+#elif defined(OS_MACOSX) || defined(OS_WIN) || defined(OS_CHROMEOS) || \
+ defined(OS_LINUX)
+ report.set_platform_type(PermissionReport::DESKTOP_PLATFORM);
+#else
+#error Unsupported platform.
+#endif
+
+ // Collect field trial data.
+ std::vector<variations::ActiveGroupId> active_group_ids;
+ variations::GetFieldTrialActiveGroupIds(&active_group_ids);
+ for (auto active_group_id : active_group_ids) {
+ PermissionReport::FieldTrial* field_trial = report.add_field_trials();
+ field_trial->set_name_id(active_group_id.name);
+ field_trial->set_group_id(active_group_id.group);
+ }
return report.SerializeToString(output);
}
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/permission_reporter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698