chrome/browser/resources/md_history/history.html - Issue 2073703002: MD History: Simplify flex layout in <history-list>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history.html

Issue 2073703002: MD History: Simplify flex layout in <history-list> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove flex usage from app and history.html Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/app.html ('K') | « chrome/browser/resources/md_history/app.html ('k') | chrome/browser/resources/md_history/history_item.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history.html

diff --git a/chrome/browser/resources/md_history/history.html b/chrome/browser/resources/md_history/history.html

index 009049ab7fe815776d2511e4cbf1388d352e030d..1c15c5c8332f6235789bc09c4670c9120b735515 100644

--- a/chrome/browser/resources/md_history/history.html

+++ b/chrome/browser/resources/md_history/history.html

@@ -16,38 +16,41 @@

body {

background: var(--md-background-color);

- display: flex;

- flex-direction: column;

}

/* Minimal styling required to display app shim. */

- .loading history-app,

- .app-shim {

- display: none;

+ .loading history-app {

+ visibility: hidden;

}

- history-app {

- flex: 1;

+ #app-shim {

+ display: none;

}

- .loading .app-shim {

+ .loading #app-shim {

+ bottom: 0;

display: flex;

+ flex-direction: column;

font-size: 123%;

+ height: 100%;

+ left: 0;

+ position: absolute;

+ right: 0;

+ top: 0;

+ }

+ #app-shim span {

+ display: flex;

}

.loading #loading-toolbar {

-webkit-padding-start: 24px;

align-items: center;

+ background: var(--md-toolbar-color);

color: #fff;

- flex-direction: row;

- font-weight: 400;

height: 56px;

}

- .loading #loading-toolbar {

- background: var(--md-toolbar-color);

- }

.loading #loading-message {

align-items: center;

color: #b4b4b4;

@@ -60,8 +63,11 @@

<history-app id="history-app"></history-app>

- <span class="app-shim" id="loading-toolbar">$i18n{title}</span>

- <span class="app-shim" id="loading-message">$i18n{loading}</span>

+ <div id="app-shim">

+ <span id="loading-toolbar">$i18n{title}</span>

+ <span id="loading-message">$i18n{loading}</span>

+ </div>