MD History: Simplify flex layout in <history-list>

MD History: Simplify flex layout

MD History was using flexbox where it was not required, resulting in a
significant performance regression following crbug.com/397888. This CL
simplifies the layout to workaround this regression, replacing flex
layout with block layout in history.html, <history-app>, and
<history-list>. Also changes the amount of padding at the top of the
list, per feedback from UI.

BUG=618153
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/07a903c7055b1d2bf30d33f383c188418bc3cd50
Cr-Commit-Position: refs/heads/master@{#401168}

[tsergeant, 2016-06-16 07:23:17]

Description was changed from

==========
MD History: Simplify flex layout in <history-list>

MD History was using flexbox where it was not required, resulting in a
significant performance regression following crbug.com/397888. This CL
simplifies the layout to workaround this regression. Also changes the
amount of padding at the top of the list, per feedback from UI.

BUG=618513
==========

to

==========
MD History: Simplify flex layout in <history-list>

MD History was using flexbox where it was not required, resulting in a
significant performance regression following crbug.com/397888. This CL
simplifies the layout to workaround this regression. Also changes the
amount of padding at the top of the list, per feedback from UI.

BUG=618513
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-06-16 07:56:56]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2016-06-20 01:40:23]

Description was changed from

==========
MD History: Simplify flex layout in <history-list>

MD History was using flexbox where it was not required, resulting in a
significant performance regression following crbug.com/397888. This CL
simplifies the layout to workaround this regression. Also changes the
amount of padding at the top of the list, per feedback from UI.

BUG=618513
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Simplify flex layout

MD History was using flexbox where it was not required, resulting in a
significant performance regression following crbug.com/397888. This CL
simplifies the layout to workaround this regression, replacing flex
layout with block layout in history.html, <history-app>, and
<history-list>. Also changes the amount of padding at the top of the
list, per feedback from UI.

BUG=618513
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-06-20 01:48:15]

I've substantially updated this CL to tackle all of the layout issues in one go.
This includes taking into account the sidebar, so I'll update the hidden drawer
CL to be based off this one.

PTAL.

https://codereview.chromium.org/2073703002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.html (right):

https://codereview.chromium.org/2073703002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/app.html:34: float: left;
This will be going away "soon".

[tsergeant, 2016-06-20 07:05:17]

Patchset #3 (id:40001) has been deleted

[tsergeant, 2016-06-20 07:16:23]

Description was changed from

==========
MD History: Simplify flex layout

MD History was using flexbox where it was not required, resulting in a
significant performance regression following crbug.com/397888. This CL
simplifies the layout to workaround this regression, replacing flex
layout with block layout in history.html, <history-app>, and
<history-list>. Also changes the amount of padding at the top of the
list, per feedback from UI.

BUG=618513
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Simplify flex layout

MD History was using flexbox where it was not required, resulting in a
significant performance regression following crbug.com/397888. This CL
simplifies the layout to workaround this regression, replacing flex
layout with block layout in history.html, <history-app>, and
<history-list>. Also changes the amount of padding at the top of the
list, per feedback from UI.

BUG=618153
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-06-20 07:16:34]

Patchset #3 (id:60001) has been deleted

[tsergeant, 2016-06-20 07:16:46]

Patchset #3 (id:80001) has been deleted

[calamity, 2016-06-21 08:18:00]

https://codereview.chromium.org/2073703002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2073703002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_history/shared_style.html:14: --toolbar-height:
56px;
Changing these won't change the toolbar height or the grouped height. Seems
dodgy.

You can definitely lock these to the paper-tabs height and the
#toolbar-container height in some fashion.

[tsergeant, 2016-06-22 01:13:45]

https://codereview.chromium.org/2073703002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2073703002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_history/shared_style.html:14: --toolbar-height:
56px;
On 2016/06/21 08:18:00, calamity wrote:
> Changing these won't change the toolbar height or the grouped height. Seems
> dodgy.
> 
> You can definitely lock these to the paper-tabs height and the
> #toolbar-container height in some fashion.

Done.

[calamity, 2016-06-22 01:17:11]

lgtm

[tsergeant, 2016-06-22 01:27:59]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-06-22 01:28:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073703002/120001

[commit-bot: I haz the power, 2016-06-22 02:19:50]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-06-22 02:23:44]

Description was changed from

==========
MD History: Simplify flex layout

MD History was using flexbox where it was not required, resulting in a
significant performance regression following crbug.com/397888. This CL
simplifies the layout to workaround this regression, replacing flex
layout with block layout in history.html, <history-app>, and
<history-list>. Also changes the amount of padding at the top of the
list, per feedback from UI.

BUG=618153
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Simplify flex layout

MD History was using flexbox where it was not required, resulting in a
significant performance regression following crbug.com/397888. This CL
simplifies the layout to workaround this regression, replacing flex
layout with block layout in history.html, <history-app>, and
<history-list>. Also changes the amount of padding at the top of the
list, per feedback from UI.

BUG=618153
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/07a903c7055b1d2bf30d33f383c188418bc3cd50
Cr-Commit-Position: refs/heads/master@{#401168}
==========

[commit-bot: I haz the power, 2016-06-22 02:23:45]

Patchset 4 (id:??) landed as
https://crrev.com/07a903c7055b1d2bf30d33f383c188418bc3cd50
Cr-Commit-Position: refs/heads/master@{#401168}

[Dan Beam, 2016-08-23 21:01:17]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-08-23 21:01:18]

https://codereview.chromium.org/2073703002/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_history/app.html (right):

https://codereview.chromium.org/2073703002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_history/app.html:43: float: left;
this doesn't flip in RTL in case you thought it would