chrome/browser/nacl_host/pnacl_translation_cache.cc - Issue 20737002: Change the API of disk_cache::CreateCacheBackend to use scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/pnacl_translation_cache.cc

Issue 20737002: Change the API of disk_cache::CreateCacheBackend to use scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix new test Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/nacl_host/pnacl_translation_cache.cc

diff --git a/chrome/browser/nacl_host/pnacl_translation_cache.cc b/chrome/browser/nacl_host/pnacl_translation_cache.cc

index a5f8eb6e84b26cc1d41687a3a30d6d9939210330..fa548f1f70d7e77184cb0f443707d4e4940a083b 100644

--- a/chrome/browser/nacl_host/pnacl_translation_cache.cc

+++ b/chrome/browser/nacl_host/pnacl_translation_cache.cc

@@ -304,10 +304,9 @@ void PnaclTranslationCache::OpComplete(PnaclTranslationCacheEntry* entry) {

//////////////////////////////////////////////////////////////////////

// Construction and cache backend initialization

-PnaclTranslationCache::PnaclTranslationCache()

- : disk_cache_(NULL), in_memory_(false) {}

+PnaclTranslationCache::PnaclTranslationCache() : in_memory_(false) {}

-PnaclTranslationCache::~PnaclTranslationCache() { delete disk_cache_; }

+PnaclTranslationCache::~PnaclTranslationCache() {}

int PnaclTranslationCache::InitWithDiskBackend(

const base::FilePath& cache_dir,