Issue 2073623002: Simplify generated code for assert()

Issue 2073623002: Simplify generated code for assert() (Closed)

Created:
4 years, 6 months ago by hausner

Modified:
4 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Lasse Reichstein Nielsen

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Simplify generated code for assert() Move the assert condition check and throwing the error into the Dart library. This eliminates one call to library code. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/98033d413289b6302619b71d61790be15562a984

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -36 lines)			Patch
M	runtime/lib/errors.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/errors_patch.dart	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	runtime/vm/parser.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+10 lines, -30 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (4 generated)

hausner

4 years, 6 months ago (2016-06-16 17:44:36 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
98033d413289b6302619b71d61790be15562a984 (presubmit successful).