Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2073603002: Add shippingOption to PaymentResponse (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add shippingOption to PaymentResponse PaymentRequest lets web developers access the shipping option String through the PaymentRequest object. As it is a part of information necessary to complete a transaction, it makes sense to place this information in PaymentResponse as well. https://w3c.github.io/browser-payment-api/#paymentresponse-interface https://github.com/w3c/browser-payment-api/commit/47db154ac80a1b1b6bfde4627eab6f496e47670c * All tests for PaymentRequest::OnPaymentResponse() have been moved into OnPaymentResponseTest.cpp. * The shipping_option_id field in Mojo is renamed to shipping_option to match the JavaScript API. BUG=587995 Committed: https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286 Cr-Commit-Position: refs/heads/master@{#400545}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -337 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/android/payments/dynamic_shipping.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/android/payments/free_shipping.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp View 1 2 1 chunk +458 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 1 2 3 chunks +0 lines, -329 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.idl View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/payments/payment_request.mojom View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
please use gerrit instead
(mek@ is ooo ? haraken@ : mek@), ptal WebKit. dfalcantara@, ptal android. palmer@, ptal payment_request.mojom.
4 years, 6 months ago (2016-06-15 23:02:30 UTC) #3
haraken
WebKit LGTM (but I just reviewed in terms of implementation).
4 years, 6 months ago (2016-06-16 00:44:09 UTC) #4
Marijn Kruisselbrink
lgtm
4 years, 6 months ago (2016-06-16 07:04:02 UTC) #5
gone
android lgtm
4 years, 6 months ago (2016-06-16 18:25:01 UTC) #6
palmer
lgtm
4 years, 6 months ago (2016-06-16 22:32:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073603002/60001
4 years, 6 months ago (2016-06-17 20:32:46 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-17 23:38:58 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 23:40:33 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1532d8d156be95a9bc272cc9fcbb96c00a67c286
Cr-Commit-Position: refs/heads/master@{#400545}

Powered by Google App Engine
This is Rietveld 408576698