Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2073593002: Revert of Keep SkColorSpace and SkColorProfileType in sync (Closed)

Created:
4 years, 6 months ago by egdaniel
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Keep SkColorSpace and SkColorProfileType in sync (patchset #2 id:20001 of https://codereview.chromium.org/2068743003/ ) Reason for revert: breaking roll. ../../third_party/skia/include/core/SkImageInfo.h:202: error: undefined reference to 'SkColorSpace::NewNamed(SkColorSpace::Named)' Original issue's description: > Keep SkColorSpace and SkColorProfileType in sync > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068743003 > > Committed: https://skia.googlesource.com/skia/+/04d35bd80dde7cace866781037cbbdcab14ab683 TBR=reed@google.com,brianosman@google.com,herb@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/d2fd9e9f4f236d57eab9ea3f5b4b23032fe39fd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M include/core/SkImageInfo.h View 3 chunks +3 lines, -9 lines 0 comments Download
M tests/ImageIsOpaqueTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
egdaniel
Created Revert of Keep SkColorSpace and SkColorProfileType in sync
4 years, 6 months ago (2016-06-15 22:39:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073593002/1
4 years, 6 months ago (2016-06-15 22:39:08 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 22:39:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d2fd9e9f4f236d57eab9ea3f5b4b23032fe39fd5

Powered by Google App Engine
This is Rietveld 408576698